-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor how linux_x64_clang_debug
uses Docker and scripts.
#18255
Refactor how linux_x64_clang_debug
uses Docker and scripts.
#18255
Conversation
# Note: not using ccache here. Debug builds need a lot of cache space | ||
# and caching only provides marginal build time improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a 2GB cache getting 11 / 5262 cache hits:
https://github.com/iree-org/iree/actions/runs/10411642302/job/28835942071#step:15:6
Soooo not possible using these cache settings and a local cache (backed up GitHub Actions Cache for save/restore). Might be able to use different settings like sccache or more compression, but it seems like the cache only saves 2 minutes on an 11 minute build for -DCMAKE_BUILD_TYPE=Debug
anyways 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduced build time, yeah!
From an outsiders perspective it might not be obvious to understand why only building the project without running is useful. As the samples get build the compiler is used to compile those, but it may not be immediately clear. Thus, we could think about documenting what kind of workflows we're running why at some point.
https://iree.dev/developers/general/github-actions/#other-build-configurations
For this 'debug' build, we sometimes see build issues only appear in debug (NDEBUG set/unset). Runtime failures unique to debug are also possible, but I think we could add a few smoketests for that instead of relying on building the |
Co-authored-by: Marius Brehler <[email protected]>
Progress on #15332 and #18238 .
Similar to #18252, this drops a dependency on the
build_tools/docker/docker_run.sh
script. Unlike that PR, this goes a step further and also stops usingbuild_tools/cmake/build_all.sh
.Functional changes:
iree-test-deps
http://storage.googleapis.com/iree-sccache/ccache
(which uses GCP for storage and needs GCP auth)iree-test-deps
provides equivalent time savingsLogs before: https://github.com/iree-org/iree/actions/runs/10417779910/job/28864909582 (96% cache hits, 9 minute build but 19 minutes total, due to
iree-test-deps
)Logs after: https://github.com/iree-org/iree/actions/runs/10423409599/job/28870060781?pr=18255 (no cache, 11 minute build)
ci-exactly: linux_x64_clang_debug