[CPU] Switch to new pass generation tablegen definitions #18132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanhanW
force-pushed
the
cpu-pass-cleanup
branch
from
917f441 to
eb7368c
Compare
|
The |
Signed-off-by: hanhanW <[email protected]>
Signed-off-by: hanhanW <[email protected]>
Signed-off-by: hanhanW <[email protected]>
hanhanW
force-pushed
the
cpu-pass-cleanup
branch
from
c54940c to
e264154
Compare
Signed-off-by: hanhanW <[email protected]>
Signed-off-by: hanhanW <[email protected]>
|
Okay, the PR is ready to go. Can someone review it? |
MaheshRavishankar
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly an NFC change. It does more cleanups on ConvertToLLVM pass which moves private options to tablegen definition. Also, the revision removes a duplicated option from the ConvertToLLVM pass. The additional change is that it adds dependent dialects to ConvertToLLVM pass.
This is generally good because it removes the duplication of pass definition, and remove the magic numbers from the pass declarations. Before the change, we duplicate all the option default values to
Passes.h.Some passes are still defined in
Passes.hbecause passing tablegen option struct is a visual noise. It makes the pipeline configuration much cleaner.