Creating reusable command buffers in stream->hal lowering. #18100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanik
added
the
compiler/dialects
benvanik
force-pushed
the
users/benvanik/indirect-cmd
branch
2 times, most recently
from
b687063 to
15cebb3
Compare
ScottTodd
approved these changes
Aug 5, 2024
benvanik
force-pushed
the
users/benvanik/indirect-cmd
branch
2 times, most recently
from
0415728 to
37c3384
Compare
|
Failures here are from the Vulkan HAL not managing descriptor sets properly. I'm going to see if I can get back to a single set for now until Vulkan can be reworked (#18121). |
An extremely naive "analysis" is used to create binding tables. This will need to improve in the future for more complex programs but seems to be sufficient today. Dynamic push constants currently disable reuse until future changes move those into uniform buffers. This is disabled by default and requires opting in via the `--iree-hal-indirect-command-buffers=true` and `--iree-hal-memoization=true` flags. As testing progresses the flags will flip to default but remain present in order to allow debugging target-specific issues with reusable/indirect command buffers. There should be no significant changes with the flags disabled. Progress on #17875.
benvanik
force-pushed
the
users/benvanik/indirect-cmd
branch
from
37c3384 to
7d16be4
Compare
benvanik
requested review from
antiagainst,
MaheshRavishankar and
kuhar
as code owners
ScottTodd
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extremely naive "analysis" is used to create binding tables. This will need to improve in the future for more complex programs but seems to be sufficient today. Dynamic push constants currently disable reuse until future changes move those into uniform buffers.
This is disabled by default and requires opting in via the
--iree-hal-indirect-command-buffers=trueand--iree-hal-memoization=trueflags. As testing progresses the flags will flip to default but remain present in order to allow debugging target-specific issues with reusable/indirect command buffers. There should be no significant changes with the flags disabled.Progress on #17875.