Move build_and_test_android from ci.yml to pkgci.yml. #18070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
added
infrastructure
ScottTodd
commented
Aug 2, 2024
Comment on lines
137
to
150
| - uses: actions/[email protected] | ||
| with: | ||
| name: build-android-arm_64 | ||
| path: ${{ env.TARGET_BUILD_DIR }} | ||
| - name: "Examining artifact directory structure" | ||
| run: ls -R ${{ env.TARGET_BUILD_DIR }} | ||
| - name: "Examining github workspace directory structure" | ||
| run: ls -R ${{ github.workspace }} | ||
| - name: "Running tests" | ||
| env: | ||
| LABEL_EXCLUDE: ${{ matrix.target.label-exclude }} | ||
| run: | | ||
| ctest -j 4 \ | ||
| --test-dir "${TARGET_BUILD_DIR}" \ |
There was a problem hiding this comment.
I'm having some trouble getting into a productive debugging workflow here.
Logs: https://github.com/iree-org/iree/actions/runs/10188925129/job/28186536935
Internal ctest changing into directory: /runner-root/actions-runner/_work/iree/iree/build-android-arm_64
Test project /runner-root/actions-runner/_work/iree/iree/build-android-arm_64
Start 1: iree/tools/test/iree_run_module_correctness_test_on_android_device
Could not find executable /home/runner/work/iree/iree/build_tools/cmake/run_android_test.sh
Looked in the following places:
Unable to find required file: /home/runner/work/iree/iree/build-android-arm_64/tools/test/iree_run_module_bytecode_module_vmvx.vmfb
May be able to test with packages from nightly releases / pypi and a non-cross-compile job doing the same steps:
- on runner A: build, upload build dir
- on runner B: download build dir, run ctest
This should be simple, but something about the paths isn't lining up the way it did when using GCS
There was a problem hiding this comment.
Test code for history / if someone wants to pick up that work: https://github.com/ScottTodd/iree/blob/540b3ed77849a2792e6f33f552c4ab37ba9c01e2/.github/workflows/pkgci_test_android.yml#L94-L154
ScottTodd
force-pushed
the
infra-pkgci-android
branch
from
540b3ed to
711108b
Compare
This currently builds but does not run any tests on real or emulated devices.
ScottTodd
force-pushed
the
infra-pkgci-android
branch
from
711108b to
6e149e8
Compare
yuennancy
approved these changes
Aug 5, 2024
ScottTodd
added a commit
that referenced
this pull request
Aug 6, 2024
…18107) Cleanup relating to #16203 and #17957. After #18070, no jobs in `ci.yml` are depending on the output of the `build_all` job. All jobs using the compiler now live in `pkgci.yml` and use packages instead of the "install dir". * The reusable [`build_all.yml`](https://github.com/iree-org/iree/blob/main/.github/workflows/build_all.yml) workflow is still in use from benchmarking workflows, but those are unmaintained and may be deleted soon. * After this is merged I'll set the `linux_x64_clang` check to "required", so PRs will need it to be passing before they can be merged. * Now that `ci.yml` is pruned to just a few remaining jobs (`build_test_all_bazel`, `build_test_runtime`, `small_runtime`, `tracing`), we can also limit when the workflow runs at all. I've added some `paths` patterns so this won't run on push events if only files under `docs/` are changed, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #16203 and #17957.
This migrates
.github/workflows/build_and_test_android.ymlto.github/workflows/pkgci_test_android.yml.For now, this only builds for Android, it does not run tests or use real Android devices at all.
The previous workflow
build_tools/docker/dockerfiles/android.Dockerfile)The new workflow
I made some attempts at passing files from the build job to a test job but ran into some GitHub Actions debugging that was tricky. Leaving the remaining migration work there to contributors at Google or other parties directly interested in Android CI infrastructure.
ci-exactly: build_packages, test_android