[VectorDistribution] Split layout configuration and distribution #18065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groverkss
requested review from
MaheshRavishankar,
qedawkins and
kuhar
as code owners
Groverkss
force-pushed
the
users/Groverkss/to-layout-split-anchor
branch
from
6cac8fa to
ab0ca3f
Compare
raikonenfnu
approved these changes
Aug 1, 2024
Groverkss
force-pushed
the
users/Groverkss/to-layout-split-anchor
branch
from
ab0ca3f to
b9f40d6
Compare
Groverkss
force-pushed
the
users/Groverkss/to-layout-split-anchor
branch
from
b9f40d6 to
b1a88ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch splits the LLVMGPUVectorDistribution pass into two separate passes, one that sets the layouts and one that distributes. This improves the debugging experience and the failing IR can be checked for the anchors.