-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onnx] Enable f64
backends for onnx
test suite
#18056
Conversation
681fa38
to
029cdc9
Compare
"--iree-input-demote-f64-to-f32" | ||
"--iree-input-demote-f64-to-f32=false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false is the default right? You can just leave the flag off then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not. I have to set to false to disable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iree/compiler/src/iree/compiler/Pipelines/Options.h
Lines 53 to 58 in 6c45bef
// Gate various type based demotion passes that run before anything else. | |
bool demoteI64ToI32 = false; | |
bool demoteF32ToF16 = false; | |
bool demoteF64ToF32 = true; | |
bool promoteF16ToF32 = false; | |
bool promoteBF16ToF32 = false; |
Test results appear mixed on https://github.com/iree-org/iree/actions/runs/10170532539/job/28130212435?pr=18056. Some newly passing, some newly failing to compile, some newly crashing while compiling :P. I think we should just test with default flags, whatever those may be. The flags that change types at the input stage are generally sketchy though, so it isn't too surprising if enabling/disabling them changes behavior in unexpected ways. |
029cdc9
to
1c223d8
Compare
Once llvm/torch-mlir#3579 merges in and sync (along with a llvm bump). We should see an increase in testing coverage. Its worth noting some of our failures are actually passing, the rtol is just too small for some tests (e.g. onnx.Pow) |
We had a discussion a while ago about updating the test suite(s) to support changing tolerances for individual tests / backends. Never followed up on that, I don't remember who was looking at it. |
1c223d8
to
738b65c
Compare
For
rocm
cpu
andcuda
we can supportf64
types for the onnx backend. It makes more sense to support testing using these types on backends where it is available.