Move ASan and TSan jobs to their own workflows. #18003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanik
approved these changes
Jul 24, 2024
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
Progress on iree-org#17957. This moves the ASan (Address Sanitizer) and TSan (Thread Sanitizer) jobs into their own workflows, so they can run based on independent triggers and can be individually enabled/disabled as needed. For now these are the triggers: * ASan runs on `pull_request` and `push` events, similar to how it ran as part of `ci.yml` * TSan runs on a nightly `schedule` and on-demand using `workflow_dispatch`. We can add other ways to trigger it like via pull request labels or git trailers as needed. Both of these jobs need more disk space than GitHub's standard runners have, so they are running on larger self-hosted runners. If we have enough runner capacity then both jobs could run on every commit (`pull_request` and `push`). I think ASan is valuable enough for that but TSan is more situational. --- For more information about these sanitizers, see * https://iree.dev/developers/debugging/sanitizers/ * https://github.com/google/sanitizers * https://clang.llvm.org/docs/AddressSanitizer.html * https://clang.llvm.org/docs/ThreadSanitizer.html * https://clang.llvm.org/docs/MemorySanitizer.html Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #17957.
This moves the ASan (Address Sanitizer) and TSan (Thread Sanitizer) jobs into their own workflows, so they can run based on independent triggers and can be individually enabled/disabled as needed.
For now these are the triggers:
pull_requestandpushevents, similar to how it ran as part ofci.ymlscheduleand on-demand usingworkflow_dispatch. We can add other ways to trigger it like via pull request labels or git trailers as needed.Both of these jobs need more disk space than GitHub's standard runners have, so they are running on larger self-hosted runners. If we have enough runner capacity then both jobs could run on every commit (
pull_requestandpush). I think ASan is valuable enough for that but TSan is more situational.For more information about these sanitizers, see