Sync SDXL benchmark metrics with latest values. #17795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Jul 2, 2024
Comment on lines
301
to
304
| --goldentime-rocm-e2e-ms 1335.0 \ | ||
| --goldentime-rocm-unet-ms 340.0 \ | ||
| --goldentime-rocm-clip-ms 17.0 \ | ||
| --goldentime-rocm-vae-ms 290.0 \ |
There was a problem hiding this comment.
These might be tight. Presubmit got:
- 1334 (-1 from 1335)
- 339 (-1 from 340)
- 16.3 (-0.7 from 17.0)
- 290.0 (-0 from 290.0)
There was a problem hiding this comment.
unet and clip are pretty stable usually so that should be fine. vae and e2e might have a bit more variation though, so might want to add a bit more leniency there (1336 and 291?)
saienduri
approved these changes
Jul 2, 2024
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
Benchmark metrics improved (when using `--iree-llvmgpu-enable-prefetch=true`), so locking in the improvements. Context: iree-org#17744 (comment) Presubmit results: https://github.com/iree-org/iree/actions/runs/9765047731/attempts/1#summary-26955236756 Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark metrics improved (when using
--iree-llvmgpu-enable-prefetch=true), so locking in the improvements. Context: #17744 (comment)Presubmit results: https://github.com/iree-org/iree/actions/runs/9765047731/attempts/1#summary-26955236756