[hip] Optionally enable graph-based command buffer and add tests #16604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit made `hipDrvGraphAddMemcpyNode` as an optional symbol so that even when we are missing it we can still build the hip HAL river without problem. Instead it will error out at runtime. This allows us to start testing the hip graph based command buffer. For that, tests are registered.
antiagainst
requested review from
benvanik and
stellaraccident
as code owners
benvanik
changed the title
benvanik
reviewed
Feb 28, 2024
benvanik
approved these changes
Feb 29, 2024
antiagainst
force-pushed
the
hip-graph-optional-symbol
branch
from
13b9fba to
02cb731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit made
hipDrvGraphAddMemcpyNodeas an optional symbol so that even when we are missing it we can still build the hip HAL driver without problem. Instead it will error out at runtime. This allows us to start testing the hip graph based command buffer. For that, tests are registered.