Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let EncodingAttr track the op type #17604

Closed
Tracked by #17608
bjacob opened this issue Jun 7, 2024 · 0 comments · Fixed by #17756
Closed
Tracked by #17608

Let EncodingAttr track the op type #17604

bjacob opened this issue Jun 7, 2024 · 0 comments · Fixed by #17756
Assignees

Comments

@bjacob
Copy link
Contributor

bjacob commented Jun 7, 2024

Currently we only data-tile matmuls. When we start data-tiling convs, we will need to track in the encoding the type of op using the encoded tensors. This doesn't map 1:1 to linalg named ops. This could be a new enumeration attribute, EncodingOpType, that could for now have a single value MATMUL (used for all of the flavors of matmuls that we currently handle, including batch matmuls, vecmat, matvec etc). Then when we start data-tiling convs, there could be a new value CONV.

Note: in the past we used to have such an enum, EncodingUser. I don't think that was a great name.

lialan added a commit that referenced this issue Jul 9, 2024
This is to get encoding ready for ops other than MATMUL.

Resolves #17604

Signed-off-by: Alan Li <[email protected]>
LLITCHEV pushed a commit to LLITCHEV/iree that referenced this issue Jul 30, 2024
This is to get encoding ready for ops other than MATMUL.

Resolves iree-org#17604

Signed-off-by: Alan Li <[email protected]>
Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants