Skip to content

Commit

Permalink
Add timeouts to pytest cases in pkgci/iree_tests. (#16703)
Browse files Browse the repository at this point in the history
When a test times out the error messages are basically useless (for the
entire run, not just the specific test cases), since
https://pypi.org/project/pytest-timeout/ terminates the test rather
forcefully... but timing out is still better than running forever. For
the test cases in #16666 that
timed out, I just excluded them from the test job configs.
  • Loading branch information
ScottTodd authored Mar 7, 2024
1 parent 0545746 commit f513fe2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pkgci_regression_test_amdgpu_rocm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,4 @@ jobs:
run: |
source ${VENV_DIR}/bin/activate
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/opt/rocm/lib:/opt/rocm/hip/lib
pytest SHARK-TestSuite/iree_tests -n 4 -rpfE
pytest SHARK-TestSuite/iree_tests -n 4 -rpfE --timeout=60
2 changes: 1 addition & 1 deletion .github/workflows/pkgci_regression_test_amdgpu_vulkan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,4 @@ jobs:
IREE_TEST_CONFIG_FILES: experimental/regression_suite/external_test_suite/config_gpu_vulkan.json
run: |
source ${VENV_DIR}/bin/activate
pytest SHARK-TestSuite/iree_tests -n 4 -rpfE
pytest SHARK-TestSuite/iree_tests -n 4 -rpfE --timeout=60
2 changes: 1 addition & 1 deletion .github/workflows/pkgci_regression_test_cpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,4 @@ jobs:
IREE_TEST_CONFIG_FILES: experimental/regression_suite/external_test_suite/config_cpu_llvm_sync.json
run: |
source ${VENV_DIR}/bin/activate
pytest SHARK-TestSuite/iree_tests -n auto -rpfE
pytest SHARK-TestSuite/iree_tests -n auto -rpfE --timeout=60

0 comments on commit f513fe2

Please sign in to comment.