Skip to content

Commit

Permalink
Revert "[hip] Fixed a busy wait in event_semaphore." (#19548)
Browse files Browse the repository at this point in the history
Reverts #19540
This might be causing flakes in some of the bots.
  • Loading branch information
AWoloszyn authored Dec 20, 2024
1 parent 0a0483e commit 76a7b89
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions runtime/src/iree/hal/drivers/hip/event_semaphore.c
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,10 @@ static iree_status_t iree_hal_hip_semaphore_wait(
iree_notification_prepare_wait(&semaphore->state_notification);
iree_slim_mutex_unlock(&semaphore->mutex);

// We are going to pick up the correct status from query_locked below.
iree_status_ignore(
iree_hal_hip_event_semaphore_run_scheduled_callbacks(base_semaphore));

// We have to wait for the semaphore to catch up.
bool committed =
iree_notification_commit_wait(&semaphore->state_notification, wait,
Expand Down

0 comments on commit 76a7b89

Please sign in to comment.