Address comments

compiler/src/iree/compiler/Codegen/Dialect/VectorExt/Transforms/VectorExtFoldUnitExtentDims.cpp

@@ -24,11 +24,10 @@ struct DropToLayoutUnitDims final
   LogicalResult matchAndRewrite(IREE::VectorExt::ToLayoutOp toLayoutOp,
                                 PatternRewriter &rewriter) const override {
     if (!toLayoutOp.hasTensorSemantics()) {
-      return failure();
+      return rewriter.notifyMatchFailure(toLayoutOp,
+                                         "requires tensor semanticS");
     }
 
-    rewriter.setInsertionPoint(toLayoutOp);
-
     Location loc = toLayoutOp.getLoc();
     ShapedType inputTy = toLayoutOp.getType();
     ArrayRef<int64_t> shape = inputTy.getShape();
@@ -67,6 +66,8 @@ struct DropToLayoutUnitDims final
         toLayoutOp->getDiscardableAttrDictionary());
 
     // Expand to preserve output shape using insert_slice.
+    // Here, since the shape comes from the result of a to_layout op, it will
+    // always be static.
     Value dest =
         rewriter.create<tensor::EmptyOp>(loc, shape, inputTy.getElementType());
 

compiler/src/iree/compiler/Codegen/LLVMGPU/LLVMGPUConfigureTensorLayouts.cpp

@@ -38,7 +38,7 @@ LogicalResult setContractionAnchor(IREE::GPU::MMAScheduleAttr schedule,
   FailureOr<VectorContractOpInfo> opInfo =
       VectorContractOpInfo::inferFromIndexingMaps(
           contract.getIndexingMapsArray());
-  assert(succeeded(opInfo) && "contraction should have been infered");
+  assert(succeeded(opInfo) && "contraction should have been inferred");
 
   auto layouts = schedule.getContractionLayout(opInfo.value(), contract);
   if (failed(layouts)) {

compiler/src/iree/compiler/Codegen/Utils/VectorOpUtils.cpp

@@ -28,6 +28,13 @@ std::pair<int, int> VectorContractOpInfo::getResultMNIndex() const {
 
 FailureOr<VectorContractOpInfo>
 VectorContractOpInfo::inferFromIndexingMaps(ArrayRef<AffineMap> maps) {
+  // Ensure all maps are projected permutations.
+  if (!llvm::all_of(maps, [](AffineMap map) {
+        return map.isProjectedPermutation(/*allowZeroInResults=*/true);
+      })) {
+    return failure();
+  }
+
   auto maybeContractionDims = linalg::inferContractionDims(maps);
   if (failed(maybeContractionDims)) {
     return failure();