chathistory: add cursors #525
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves reliability of timestamp-based queries by using an opaque cursor. A message at a page boundary can be missed by a client if one of its neighbours has the same timestamp.
Merged
slingamn
reviewed
Jun 2, 2023
| CHATHISTORY TARGETS <timestamp> <timestamp> <limit> | ||
|
|
||
| The `target` parameter specifies a single buffer (channel or nickname) from which history is to be retrieved. If a nickname is given as the `target` then the server SHOULD include history sent between the current user and the target nickname, including outgoing messages ("self messages"). The server SHOULD attempt to include history involving other nicknames if either the current user or the target nickname has changed during the requested timeframe. | ||
|
|
||
| A `timestamp` parameter MUST have the format `timestamp=YYYY-MM-DDThh:mm:ss.sssZ`, as in the [server-time][server-time] extension. A `msgid` parameter MUST have the format `msgid=foobar`, as in the [message-ids][message-ids] extension. | ||
| A `timestamp` parameter MUST have the format `timestamp=YYYY-MM-DDThh:mm:ss.sssZ`, as in the [server-time][server-time] extension. A `msgid` parameter MUST have the format `msgid=foobar`, as in the [message-ids][message-ids] extension. A `cursor` parameter MUST have the format `cursor=foobar`. |
There was a problem hiding this comment.
Add cursor to the possible MSGREFTYPES?
There was a problem hiding this comment.
Why? If servers don't support cursors, they simply won't send CHATHISTORY CURSOR. Meanwhile, MSGREFTYPES might be useful for non-CHATHISTORY stuff in the future, where cursor wouldn't make sense.
progval
reviewed
Jun 2, 2023
|
|
||
| CHATHISTORY CURSORS <target> <next> [prev] | ||
|
|
||
| `next` is a a cursor which can be used to query the next page of messages. `prev` is a cursor which can be used to query the previous page of messages, it MUST only be returned in response to `CHATHISTORY AROUND`. |
There was a problem hiding this comment.
What if a server has a prev cursor but no next cursor in response to CHATHISTORY AROUND?
There was a problem hiding this comment.
What about CHATHISTORY CURSORS <target> {<next>|*} {<prev>|*} for CHATHISTORY AROUND and CHATHISTORY CURSORS ` for the others?
progval
added a commit
to progval/matrix2051
that referenced
this pull request
Jun 2, 2023
ircv3/ircv3-specifications#525 Not tested live yet
|
Impl in M51: progval/matrix2051#55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves reliability of timestamp-based queries by using an opaque cursor. A message at a page boundary can be missed by a client if one of its neighbours has the same timestamp.