mgm: Generalize TDES logic to enable other algorithms #588
+393
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
330-mgm-generalization
branch
from
8995d74 to
7e437c9
Compare
str4d
force-pushed
the
330-mgm-generalization
branch
2 times, most recently
from
4df88c6 to
622d989
Compare
|
@str4d if you can rebase and remove draft we can get this reviewed |
str4d
force-pushed
the
330-mgm-generalization
branch
from
622d989 to
aaae123
Compare
|
Rebased on |
str4d
force-pushed
the
330-mgm-generalization
branch
from
aaae123 to
4c00e0b
Compare
|
Force-pushed to fix a rebase bug. |
Co-authored-by: Greg Bowyer <[email protected]>
str4d
force-pushed
the
330-mgm-generalization
branch
from
4c00e0b to
ca197e1
Compare
|
Force-pushed to update a new test for the generalization. |
Comment on lines
+214
to
+215
| /// TODO: Can we distinguish DES from AES-192? Or do we take `C` as a parameter and | ||
| /// require the caller to know the type of the bytes they are parsing? |
There was a problem hiding this comment.
I'm not sure you can take a generic cipher instance since you're trying to map concrete ciphers to an enum. I think you either need some kind of separate algorithm identifier enum you can pass as a parameter, or to have separate constructor functions per algorithm.
|
|
||
| /// Derives a management key (MGM) with the given algorithm from a stored salt. | ||
| /// | ||
| /// TODO: Is this supported for AES? Is the algorithm supposed to be dynamic? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #330.
Includes #584 because I don't have write permissions on the repo and thus can't create stacked PRs directly.