Adds support for YubiHSM Auth #459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/yubihsm-auth
branch
4 times, most recently
from
e9ed2e0 to
7399525
Compare
baloo
force-pushed
the
baloo/yubihsm-auth
branch
2 times, most recently
from
5757fa2 to
0d326a4
Compare
baloo
force-pushed
the
baloo/yubihsm-auth
branch
3 times, most recently
from
9767b27 to
e3f093c
Compare
baloo
force-pushed
the
baloo/yubihsm-auth
branch
from
e3f093c to
fb561ad
Compare
baloo
force-pushed
the
baloo/yubihsm-auth
branch
2 times, most recently
from
482437a to
b26f6c9
Compare
baloo
force-pushed
the
baloo/yubihsm-auth
branch
from
b26f6c9 to
9da3725
Compare
baloo
force-pushed
the
baloo/yubihsm-auth
branch
from
9da3725 to
0dfb48c
Compare
baloo
force-pushed
the
baloo/yubihsm-auth
branch
3 times, most recently
from
49bf001 to
19a61e6
Compare
Draft
|
This one will conflict on dependencies version because yubikey.rs bumped to pre-releases |
baloo
force-pushed
the
baloo/yubihsm-auth
branch
4 times, most recently
from
f434a39 to
c3c89b4
Compare
baloo
force-pushed
the
baloo/yubihsm-auth
branch
from
c3c89b4 to
8456e87
Compare
This adds support for the YubiHSM Auth protocol as described in https://docs.yubico.com/yesdk/users-manual/application-yubihsm-auth/interacting-yubihsm-2.html This protocol ensure the derivation password for the authentication keys are kept in secure devices.
baloo
force-pushed
the
baloo/yubihsm-auth
branch
from
8456e87 to
092cbcf
Compare
baloo
commented
Feb 13, 2025
| } | ||
|
|
||
| #[cfg(feature = "yubihsm-auth")] | ||
| impl From<yubikey::hsmauth::SessionKeys> for SessionKeys { |
There was a problem hiding this comment.
so this brings a dependency on yubikey.rs just because of SessionKeys, Challenge and Context, but maybe this isn't the correct way to do this and it would be easier to rely on the inner slice instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the YubiHSM Auth protocol as described in https://docs.yubico.com/yesdk/users-manual/application-yubihsm-auth/interacting-yubihsm-2.html
This protocol ensure the derivation password for the authentication keys are kept in secure devices.
This works with iqlusioninc/yubikey.rs#492