Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Fix decoding of variable-length sequence values #86

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

tony-iqlusion
Copy link
Member

Also adds tests for decoding byte and string sequences

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #86 into develop will increase coverage by 6.45%.
The diff coverage is 84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #86      +/-   ##
===========================================
+ Coverage    72.83%   79.28%   +6.45%     
===========================================
  Files           14       14              
  Lines          600      618      +18     
===========================================
+ Hits           437      490      +53     
+ Misses         163      128      -35
Impacted Files Coverage Δ
rust/src/decoder/sequence.rs 80.37% <84%> (+43.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab2d35...8d1fa86. Read the comment docs.

Also adds tests for decoding byte and string sequences
@tarcieri tarcieri force-pushed the rust/fix-sequence-decoding branch from 16a83eb to 8d1fa86 Compare February 26, 2020 19:45
@tony-iqlusion tony-iqlusion merged commit ed80b35 into develop Feb 26, 2020
@tony-iqlusion tony-iqlusion deleted the rust/fix-sequence-decoding branch February 26, 2020 19:56
@tony-iqlusion tony-iqlusion mentioned this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants