Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tendermint-rs to v0.17.0-rc2 #222

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Conversation

tony-iqlusion
Copy link
Member

No description provided.

@tony-iqlusion
Copy link
Member Author

This almost compiles! 🎉

The one remaining problem is how to or whether it's still possible to serialize/deserialize tendermint::consensus::State as JSON.

@greg-szabo is this still possible, and if so, how do I make it work?

     |                                       ^^^^^^^^^^^^^^^^^^^^ the trait `config::_::_serde::Deserialize<'_>` is not implemented for `tendermint::consensus::State`
     |
    ::: /Users/bascule/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/serde_json-1.0.59/src/de.rs:2584:8
     |
2584 |     T: de::Deserialize<'a>,
     |        ------------------- required by this bound in `serde_json::from_str`

error[E0277]: the trait bound `tendermint::consensus::State: config::_::_serde::Deserialize<'_>` is not satisfied
    --> src/chain/state.rs:36:39
     |
36   |                 let consensus_state = serde_json::from_str(&state_json).map_err(|e| {
     |                                       ^^^^^^^^^^^^^^^^^^^^ the trait `config::_::_serde::Deserialize<'_>` is not implemented for `tendermint::consensus::State`
     |
    ::: /Users/bascule/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/serde_json-1.0.59/src/de.rs:2584:8
     |
2584 |     T: de::Deserialize<'a>,
     |        ------------------- required by this bound in `serde_json::from_str`

error[E0277]: the trait bound `tendermint::consensus::State: config::_::_serde::Serialize` is not satisfied
    --> src/chain/state.rs:188:42
     |
188  |         let json = serde_json::to_string(&self.consensus_state)?;
     |                                          ^^^^^^^^^^^^^^^^^^^^^ the trait `config::_::_serde::Serialize` is not implemented for `tendermint::consensus::State`
     |
    ::: /Users/bascule/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/serde_json-1.0.59/src/ser.rs:2221:17
     |
2221 |     T: ?Sized + Serialize,
     |                 --------- required by this bound in `serde_json::to_string`

error[E0277]: the trait bound `tendermint::consensus::State: config::_::_serde::Serialize` is not satisfied
    --> src/chain/state.rs:188:42
     |
188  |         let json = serde_json::to_string(&self.consensus_state)?;
     |                                          ^^^^^^^^^^^^^^^^^^^^^ the trait `config::_::_serde::Serialize` is not implemented for `tendermint::consensus::State`
     |
    ::: /Users/bascule/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/serde_json-1.0.59/src/ser.rs:2221:17
     |
2221 |     T: ?Sized + Serialize,
     |                 --------- required by this bound in `serde_json::to_string`

@tarcieri tarcieri force-pushed the tendermint-rs/v0.17.0-rc2 branch from 35b3509 to 5a91c55 Compare November 16, 2020 18:51
@tony-iqlusion tony-iqlusion marked this pull request as ready for review November 16, 2020 18:51
@tony-iqlusion tony-iqlusion changed the title [WIP] Bump tendermint-rs to v0.17.0-rc2 Bump tendermint-rs to v0.17.0-rc2 Nov 16, 2020
@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

Merging #222 (734c987) into develop (7ab58bc) will increase coverage by 0.05%.
The diff coverage is 15.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #222      +/-   ##
===========================================
+ Coverage    25.55%   25.60%   +0.05%     
===========================================
  Files           78       79       +1     
  Lines         3135     3163      +28     
===========================================
+ Hits           801      810       +9     
- Misses        2334     2353      +19     
Impacted Files Coverage Δ
src/amino_types.rs 0.00% <ø> (ø)
src/amino_types/block_id.rs 0.00% <0.00%> (ø)
src/amino_types/proposal.rs 40.45% <0.00%> (ø)
src/amino_types/vote.rs 56.21% <0.00%> (ø)
src/chain.rs 0.00% <0.00%> (ø)
src/chain/registry.rs 0.00% <0.00%> (ø)
src/commands/ledger.rs 0.00% <0.00%> (ø)
src/commands/yubihsm/keys/list.rs 0.00% <0.00%> (ø)
src/session.rs 0.00% <0.00%> (ø)
src/tx_signer.rs 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab58bc...734c987. Read the comment docs.

@tarcieri tarcieri force-pushed the tendermint-rs/v0.17.0-rc2 branch from 5a91c55 to 734c987 Compare November 16, 2020 19:04
@tony-iqlusion tony-iqlusion merged commit e38a6f0 into develop Nov 16, 2020
@tony-iqlusion tony-iqlusion deleted the tendermint-rs/v0.17.0-rc2 branch November 16, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants