Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc transfer authz work #1

Open
wants to merge 223 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
223 commits
Select commit Hold shift + click to select a range
77c10be
docs: updating v3->v4 migration docs with fee middleware (#2127)
seantking Sep 26, 2022
844612c
chore: add minor releases to test matrix (#2365)
colin-axner Sep 26, 2022
4014c1c
add releases and security sections (#2378)
crodriguezvega Sep 26, 2022
8a7f2bf
ibc transfer authz work
icafa Sep 27, 2022
5c3b9af
update short description to make it consistent with the rest of modul…
crodriguezvega Sep 27, 2022
587821f
Update v4-to-v5.md
crodriguezvega Sep 27, 2022
e470057
docs: add ics29 integration for sdk module (#2394)
colin-axner Sep 27, 2022
79b84be
docs: fix deploy docs workflow (#2404)
damiannolan Sep 27, 2022
875279d
chore: remove unnecessary code (#2395)
colin-axner Sep 27, 2022
06e91f4
Update release-tracker.md
crodriguezvega Sep 28, 2022
8f0e7d5
Add host cli to generate ica packet data (#2297)
chatton Sep 28, 2022
09788ec
chore: updating 09-localhost migration code to v7 (#2392)
damiannolan Sep 28, 2022
f669ab0
docs: renaming migration doc for 02-client refactor ibc-go/v7 (#2418)
damiannolan Sep 28, 2022
0168efb
Fix docs rendering issue (#2421)
chatton Sep 28, 2022
c582e8a
ADR 009: ICS 27 simplication (#2218)
colin-axner Sep 28, 2022
0d63964
Add compatibility tests for v5.0.x #2 (#2396)
chatton Sep 28, 2022
3c21b5e
Modify MsgSendTx fields based on audit (#2280)
chatton Sep 28, 2022
78249c1
Update release-tracker.md
crodriguezvega Sep 28, 2022
7408d52
Fix docs deployment (#2432)
chatton Sep 29, 2022
0f7d041
chore: add v4 to v5 migration docs to site (#2426)
colin-axner Sep 29, 2022
2fab89b
chore: add private send transfer function (#2425)
colin-axner Sep 29, 2022
363970e
updated error calls with module names (#2399)
alizahidraja Sep 29, 2022
ecee40f
chore: add v6 upgrade handler to simapp (#2383)
damiannolan Sep 29, 2022
ce5aba8
Adding GetChannelsWithPortPrefix function to 04-channel (#2304)
chatton Sep 29, 2022
ed71af8
chore: update migration template (#2423)
colin-axner Sep 29, 2022
7dcfc2c
issue#2004 : moved verifyMisbehviour function from update.go to misbe…
Daniyal98 Sep 29, 2022
462ccb6
added switch case to detect blank pointers in keeper (#2403)
alizahidraja Sep 29, 2022
ceddad5
Update CHANGELOG.md
crodriguezvega Sep 30, 2022
febe453
add new tag
crodriguezvega Sep 30, 2022
b821821
Revert "add new tag"
crodriguezvega Sep 30, 2022
9fdcf2c
v5.0.0 post release chores (#2428)
crodriguezvega Sep 30, 2022
f84bb92
add allowed address restriction for ibc transfer authz
icafa Oct 3, 2022
2b5ea19
expect error when transferring to not allowed address
icafa Oct 3, 2022
edc4fd0
move call to addConnectionToClient up (#2456)
crodriguezvega Oct 4, 2022
2056c2d
Renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix (#2450)
alizahidraja Oct 4, 2022
8c80802
build(deps): bump github.com/cosmos/cosmos-sdk from 0.46.1 to 0.46.2 …
dependabot[bot] Oct 4, 2022
3363917
MsgTransferResponse add sequence (#2377)
agouin Oct 4, 2022
503b9eb
fix golangcli-lint complaint (#2463)
crodriguezvega Oct 5, 2022
8c7c655
bump icad tag with ibc-go v5.0.0 + gofumpt (#2461)
crodriguezvega Oct 5, 2022
88525d2
Simplify SendPacket API (#1703)
AdityaSripal Oct 6, 2022
4bd05c6
chore: bump ibctest version and ibc-go version to v6 for e2e module (…
colin-axner Oct 6, 2022
6a70103
rename validateEnabled to validateEnabledType (#2469)
crodriguezvega Oct 6, 2022
126b6f3
Removed TypeMsg constants (#2478)
alizahidraja Oct 7, 2022
a23a107
Update develop.md
crodriguezvega Oct 7, 2022
a1843f8
fixing dead link to sdk v0.44 (#2488)
damiannolan Oct 7, 2022
be46857
build(deps): bump google.golang.org/grpc from 1.49.0 to 1.50.0 (#2499)
dependabot[bot] Oct 10, 2022
82397d6
Added optional packet metadata to the packet and message types (#2305)
nicolaslara Oct 10, 2022
bb7cb29
Add @damiannolan as full code owner of ibc-go (#2485)
colin-axner Oct 10, 2022
bf547e4
Update package-lock.json (#2430)
mik-patient Oct 11, 2022
4c45212
fix broken links (#2511)
crodriguezvega Oct 11, 2022
24b17bd
refactor: remove SendTransfer, require IBC transfers to be initiated …
colin-axner Oct 11, 2022
567178c
docs: update roadmap (#2460)
crodriguezvega Oct 11, 2022
c8e2ebc
Remove older mechanism for compatibility tests (#2529)
chatton Oct 11, 2022
5b5c34b
build(deps): bump docker/build-push-action from 3.1.1 to 3.2.0 (#2530)
dependabot[bot] Oct 12, 2022
b8c1462
build(deps): bump docker/login-action from 2.0.0 to 2.1.0 (#2531)
dependabot[bot] Oct 12, 2022
f693f6c
build(deps): bump docker/metadata-action from 4.0.1 to 4.1.0 (#2532)
dependabot[bot] Oct 13, 2022
5a7a5bd
Update RELEASES.md
crodriguezvega Oct 14, 2022
a822550
build(deps): bump JamesIves/github-pages-deploy-action (#2543)
dependabot[bot] Oct 14, 2022
59177c4
build(deps): bump github.com/spf13/cobra from 1.5.0 to 1.6.0 (#2533)
dependabot[bot] Oct 14, 2022
aed1dd2
feat: add semantic version utilities for e2e tests (#2502)
colin-axner Oct 14, 2022
95cec44
chore: update godocs for legacy apis on controller module (#2363)
charleenfei Oct 14, 2022
6ffce97
moved contents to bottom (#2451)
charleenfei Oct 14, 2022
8abcba0
e2e: ICS27 interchain accounts x/group integration (#2195)
damiannolan Oct 14, 2022
90b051e
docs: adding migration doc for ibc-go v6 (#2417)
damiannolan Oct 14, 2022
9eb3875
Daniyal/issue#1689 remove get versions (#2539)
Daniyal98 Oct 17, 2022
9718f2c
build(deps): bump technote-space/get-diff-action from 6.1.0 to 6.1.1 …
dependabot[bot] Oct 18, 2022
6d86aa9
build(deps): bump google.golang.org/grpc from 1.50.0 to 1.50.1 (#2557)
dependabot[bot] Oct 18, 2022
98f6e57
build(deps): bump docker/metadata-action from 4.1.0 to 4.1.1 (#2558)
dependabot[bot] Oct 18, 2022
57239b6
update link to nft transfer app (#2560)
crodriguezvega Oct 19, 2022
54ec2f2
fix bracket alignment
crodriguezvega Oct 19, 2022
0729a1c
chore: update tests to use new SendPacket API
crodriguezvega Oct 22, 2022
6927904
Revert "chore: update tests to use new SendPacket API"
crodriguezvega Oct 22, 2022
b6e0de2
build(deps): bump golangci/golangci-lint-action from 3.2.0 to 3.3.0 (…
dependabot[bot] Oct 24, 2022
866cf5d
nit: update logo (#2563)
crodriguezvega Oct 24, 2022
5ae02a3
build(deps): bump github.com/stretchr/testify from 1.8.0 to 1.8.1 (#2…
dependabot[bot] Oct 25, 2022
c615d7f
add entry for #2305
crodriguezvega Oct 25, 2022
c06c204
docs: add request for maintainership md file (#2453)
charleenfei Oct 25, 2022
da618d7
build(deps): bump github.com/spf13/cobra from 1.6.0 to 1.6.1 (#2584)
dependabot[bot] Oct 25, 2022
8ce603d
chore: update tests to use new SendPacket API (#2567)
crodriguezvega Oct 25, 2022
05685b3
refactor: adapting transfer metadata bytes field to memo string (#2595)
damiannolan Oct 26, 2022
eebe2a1
e2e: adding simd controller msg server tests (#2572)
damiannolan Oct 26, 2022
8f31ffc
docs: updating docs for memo field in ics20 transfer (#2602)
damiannolan Oct 26, 2022
3baf0a2
updating e2e fork workflow to accommodate intertx name change (#2603)
damiannolan Oct 26, 2022
8991eaa
e2e: transfer memo tests (#2306)
nicolaslara Oct 26, 2022
35b6084
add changelog entries for v5.0.0
crodriguezvega Oct 26, 2022
e3a32a6
chore: makefile cleanup/fixes (#2549)
crodriguezvega Oct 26, 2022
6105db4
use controller module address instead of module name for NewMsgChanne…
catShaark Oct 27, 2022
5cafc24
test: 03-connection e2e test param change (#2139)
seantking Oct 27, 2022
eab24e8
fix: forbid negative values for trusting period, unbonding period and…
crodriguezvega Oct 27, 2022
5260c77
refactor!: allow for serialization of proto message without fulfillme…
colin-axner Oct 27, 2022
f9bbc4f
alignment
crodriguezvega Oct 28, 2022
8290d8c
fix e2e ica tests (#2628)
crodriguezvega Oct 28, 2022
17a061c
rename `ClientParams` gRPC method to `Params` (#2573)
crodriguezvega Oct 28, 2022
5f9966b
remove port prefix requirement (#2590)
0xLaurenzo Oct 28, 2022
09de760
Update package-lock.json (#2569)
theinternetofdefcon Oct 31, 2022
623e593
Update package-lock.json (#2570)
theinternetofdefcon Oct 31, 2022
e8ff311
fix: rm bech32 check from owner address on ICA controller msgs Regist…
charleenfei Oct 31, 2022
a0e59b8
Fetch makefile dependencies before building docker image (#2615)
chatton Oct 31, 2022
29be0da
post v2.4.2, v3.3.1, v4.1.1 and v5.0.1 release chores (#2627)
crodriguezvega Nov 2, 2022
393247b
fix: skip emission of unpopulated memo field in ics20 (#2651)
colin-axner Nov 2, 2022
47e1c9a
docs: ics27 v6 documentation updates (#2561)
damiannolan Nov 2, 2022
3ecdeed
e2e: adding e2e upgrade test for ibc-go/v6 (#2490)
damiannolan Nov 2, 2022
f0980d6
e2e: add transfer with memo compatibility tests (#2640)
crodriguezvega Nov 2, 2022
e678c69
Build E2E tests in workflow (#2649)
chatton Nov 2, 2022
ce74b00
Add scopedkeeper as an interface to exported package (#2638)
Anmol1696 Nov 2, 2022
7190305
chore: add potential use cases documentation for ica (#2594)
colin-axner Nov 2, 2022
6df0e53
chore: small README nits for readability and usability (#2669)
charleenfei Nov 3, 2022
fb996ca
update code owners (#2665)
crodriguezvega Nov 3, 2022
f69761d
fix(testing): fix block proposer and allow Default gas to be modified…
ramacarlucho Nov 4, 2022
b1f494c
add check send enabled (#2679)
crodriguezvega Nov 4, 2022
c9b8064
fix: avoid race conditions in ics27 handshakes (#2682)
damiannolan Nov 7, 2022
b2bb2de
Removing stale comment (#2685)
chatton Nov 8, 2022
f02f9d1
post release chores (#2695)
crodriguezvega Nov 8, 2022
4d19c16
removed unused variables (#2692)
Daniyal98 Nov 8, 2022
088da9c
deps: updating sdk to v0.46.4 (#2647)
damiannolan Nov 8, 2022
48321ff
e2e: updating upgrade test to use msg server (#2681)
chatton Nov 8, 2022
cd228d1
chore: update protobuf generation to latest buf changes (#2705)
damiannolan Nov 9, 2022
7249d82
Update check x/bank sendEnabled link in changelog (#2714)
calvinaco Nov 9, 2022
3e8935e
e2e: fix memo test version declaration (#2723)
colin-axner Nov 10, 2022
c912fd9
chore: rm event emission after context caching (#2662)
charleenfei Nov 10, 2022
8c07cb8
post v5.1.0 release chores (#2722)
crodriguezvega Nov 12, 2022
050eefd
Update transfer-memo.json
crodriguezvega Nov 12, 2022
cce91a1
build(deps): bump github.com/spf13/viper from 1.13.0 to 1.14.0 (#2702)
dependabot[bot] Nov 14, 2022
3b2ab6a
chore: e2e for ICA reopening (#2720)
charleenfei Nov 14, 2022
2dfd275
build(deps): bump golangci/golangci-lint-action from 3.3.0 to 3.3.1 (…
dependabot[bot] Nov 14, 2022
d46f59b
Compare signature data in misbehaviours only if path differs (#2744)
chatton Nov 14, 2022
68ba375
chore: rename all occurances of smtypes and solomachinetypes import a…
chatton Nov 14, 2022
f54143e
add missing set order functions for ica (#2740)
crodriguezvega Nov 15, 2022
510afbe
test: added test to verify signbytes marshal correctly for single sig…
chatton Nov 15, 2022
1b7745f
docs: fix migration/docs for ICA controller middleware (#2737)
crodriguezvega Nov 15, 2022
fb9dedd
chore: updating `VerifyMembership` and `VerifyNonMembership` methods …
damiannolan Nov 15, 2022
65b3ddf
e2e: updated compatibility tests to support running against all unrel…
chatton Nov 15, 2022
3e072a1
chore: integrated git cliff into the code base to automate generation…
chatton Nov 15, 2022
25e6ae5
chore: fixing dead link in PR template (#2777)
chatton Nov 16, 2022
876b73a
deprecated(api)!: (06-solomachine) [#2761] removed deprecated `Client…
chatton Nov 17, 2022
a05247c
feat: adding connection params grpc and cli query (#2745)
damiannolan Nov 17, 2022
1f140ea
chore: adding sentinel path for solomachine header (#2748)
damiannolan Nov 17, 2022
cb92f6f
fix: added check for empty path in 06-solomachine (#2741)
charleenfei Nov 18, 2022
b2e7196
chore: fixing link to interchain accounts blogpost (#2787)
chatton Nov 18, 2022
db5e738
deps: bump SDK to v0.46.6 (#2784)
crodriguezvega Nov 19, 2022
805afdf
feat: authz grants for ics-20 transfers
icafa Sep 27, 2022
996448b
chore: adding migration doc for v6 to vuepress config (#2788)
damiannolan Nov 21, 2022
375b0e1
e2e: remove irrelevant compatibility tests (#2780)
crodriguezvega Nov 22, 2022
19c2029
remove link to ICS 009 (#2797)
crodriguezvega Nov 22, 2022
c40d555
chore: adding defensive checks to ics27 capability migrations (#2798)
damiannolan Nov 22, 2022
f9b8d6a
chore: move verifyMisbehavour to the top of misbehaviour_handle.go
charleenfei Nov 22, 2022
3f27d4e
chore: move solomachine CheckForMisbehaviour to `misbehaviour_handle.…
charleenfei Nov 22, 2022
7d60efa
chore: move Tendermint CheckForMisbehaviour to `misbehaviour_handle.g…
charleenfei Nov 22, 2022
fe5fb15
chore: remove custom dependabot reviewers (#2804)
colin-axner Nov 22, 2022
ac561b4
fix: allow zero proof height, solo machine discards provided proof he…
colin-axner Nov 22, 2022
43ce616
chore: mergify backport task for v5.2.x (#2806)
crodriguezvega Nov 22, 2022
bbac2b1
Save gas on IsFeeEnabled (#2786)
alpe Nov 22, 2022
6dd5881
chore: removed usage of deprecated `set-output` field in all Github w…
chatton Nov 23, 2022
50e1211
Add more events to on IBC transfer, add tests for ibc transfer event …
Anmol1696 Nov 23, 2022
ea6e42b
build(deps): bump github.com/cosmos/cosmos-proto from 1.0.0-alpha7 to…
dependabot[bot] Nov 23, 2022
86332d2
e2e: added ICS27 e2e test with governance. (#2808)
chatton Nov 23, 2022
2180fa4
feat: add helper function for parsing clientID from client state path…
colin-axner Nov 23, 2022
d90be00
e2e: add compatibility tests for ICA to v6.0.x (#2805)
crodriguezvega Nov 25, 2022
4c91765
test: updated solomachine tests to perform an ICS20 transfer instead …
chatton Nov 28, 2022
98fc95e
e2e: update icad tags for manual e2e workflow
crodriguezvega Nov 29, 2022
ddf9baf
e2e: enabling compatibility tests to be usable from other repositorie…
chatton Nov 29, 2022
9720607
feat: add optional migration pruning for tendermint consensus states …
colin-axner Nov 29, 2022
83f1cd1
feat: add AppModuleBasic for tendermint client (#2825)
colin-axner Nov 29, 2022
13e0c57
feat: add AppModuleBasic for solo machine client (#2826)
colin-axner Nov 29, 2022
8c8b0e8
feat: add automatic in-place migrations for 02-client-refactor (v7) (…
colin-axner Nov 29, 2022
2bfdbaf
build(deps): bump google.golang.org/grpc from 1.50.1 to 1.51.0 (#2794)
dependabot[bot] Nov 30, 2022
ba1e50d
e2e: add base and incentivized ica e2e tests to v6.0.x (#2832)
crodriguezvega Nov 30, 2022
53dbc41
bug: fix clientID validation regex to conform closer to spec (#2510)
odeke-em Nov 30, 2022
bfaf6e0
follow up for #2510
crodriguezvega Nov 30, 2022
b26afd4
Revert "follow up for #2510"
crodriguezvega Nov 30, 2022
1fb7713
e2e: Added support for running compatibility tests off the main branc…
chatton Nov 30, 2022
9040647
Renaming variable SubModuleName to ModuleName (#2851)
chatton Nov 30, 2022
b28cc47
Renaming variable SubmoduleName to ModuleName in 07-tendermint (#2852)
chatton Nov 30, 2022
788cc7c
refactor: rename IterateClients to IterateClientStates, add a prefix …
colin-axner Nov 30, 2022
a5e3249
chore: add upgrade handler to simapp for v6 -> v7 (#2842)
charleenfei Nov 30, 2022
1986aaf
chore: follow up for #2510 (#2854)
crodriguezvega Dec 1, 2022
e7c3427
e2e: move tag determination logic into the e2e Github workflows. (#2849)
chatton Dec 2, 2022
2132585
deps: Bump ICS 23 to v0.9.0
colin-axner Dec 4, 2022
7adae35
docs: updating v7 migration doc with generic state verification metho…
damiannolan Dec 5, 2022
4d13768
fix: fix unmarshalling of packet data in send tx CLI
crodriguezvega Dec 5, 2022
816ef50
chore: add wait time for packet relay to e2e test for ICA channel ope…
charleenfei Dec 5, 2022
0bcb95e
convert IsAllPositive to Validate
icafa Dec 5, 2022
d09caaf
Merge branch 'ibc_transfer_authz' of github.com:iqlusioninc/ibc-go in…
icafa Dec 5, 2022
3290c18
add gas cost per interation
icafa Dec 5, 2022
288f9c0
duplicated entry check
icafa Dec 5, 2022
2d33a9f
Merge branch 'main' into ibc_transfer_authz
icafa Dec 5, 2022
1742c54
chore: scaffold custom IBC light client development guide (#2860)
charleenfei Dec 5, 2022
412e213
chore: changing ibcprotocol.org to ibcprotocol.dev (#2884)
chatton Dec 6, 2022
72fe693
chore: update README to include link to IDA (#2887)
charleenfei Dec 6, 2022
85ebc84
feat: Add genesis migrations for v6 to v7. The migration migrates the…
colin-axner Dec 7, 2022
19c79ae
refactor: simplify automatic migration code by using client keeper fu…
colin-axner Dec 7, 2022
83854f4
imp(api)!: remove legacy migrations required for upgrading from Starg…
colin-axner Dec 7, 2022
6bb1543
chore: remove unnecessary file (#2898)
colin-axner Dec 7, 2022
ab2e995
Update release-tracker.md
crodriguezvega Dec 8, 2022
f5e0233
docs: v6 ICA migration docs improvements
crodriguezvega Dec 8, 2022
2728e7d
e2e: changing default relayer tag to be v2.1.2 instead of main. (#2903)
chatton Dec 8, 2022
0dc8d1d
refactor: simplify optional tendermint pruning migrations (#2862)
colin-axner Dec 8, 2022
ce4d771
chore: add tmsdkeys to CODEOWNER for docs (#2904)
colin-axner Dec 8, 2022
8ad5932
docs: add legacy docs for ICA
crodriguezvega Dec 8, 2022
04cbd60
docs: added documentation for client state methods. (#2886)
chatton Dec 8, 2022
a25a9d0
docs: improvements to ICA docs
crodriguezvega Dec 8, 2022
9d7922f
docs: move solomachine docs into the docs directory. (#2908)
chatton Dec 8, 2022
514ad39
deps: bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (#2899)
dependabot[bot] Dec 8, 2022
d1fbdbd
deps: bump github.com/cosmos/cosmos-proto from 1.0.0-alpha8 to 1.0.0-…
dependabot[bot] Dec 8, 2022
e1c29e5
update README (#2910)
charleenfei Dec 9, 2022
267359b
Update CHANGELOG.md
crodriguezvega Dec 9, 2022
a5ff864
chore: update ibctest to latest commit (#2909)
charleenfei Dec 12, 2022
bfe7ee8
Fixing markdown link (#2924)
chatton Dec 12, 2022
a322103
post v6.0.0 release chores (#2919)
crodriguezvega Dec 12, 2022
bb08f5e
docs: update integration docs to include light client registration. (…
chatton Dec 12, 2022
2220957
imp: Add `AssertEvents` which asserts events against expected event m…
Anmol1696 Dec 12, 2022
6afa1b6
e2e: adding e2e upgrade test for ibc-go v7 (#2902)
charleenfei Dec 12, 2022
cd51cc9
e2e: update tags in e2e upgrade test
crodriguezvega Dec 14, 2022
1078875
chore: use diffs to make registration more clear (#2927)
colin-axner Dec 14, 2022
2ea8655
nit: fix typo in a comment
francas Dec 14, 2022
3be0b63
refactor: require light clients to set the initial client state and c…
damiannolan Dec 15, 2022
e8f6eaf
chore: add backports for v4.3.x and v6.1.x
crodriguezvega Dec 16, 2022
ee13f34
update compatibility tests with new release branches (#2946)
crodriguezvega Dec 16, 2022
d3be95a
fix(statemachine)!: check x/bank send enabled before escrowing fees
crodriguezvega Dec 17, 2022
6604b59
chore(deps): bump goreleaser/goreleaser-action from 3 to 4 (#2932)
dependabot[bot] Dec 19, 2022
ddc4f2d
chore(api)!: removing solomachine header sequence (#2941)
damiannolan Dec 19, 2022
0deb8ad
chore(deps): bump bufbuild/buf-setup-action from 1.9.0 to 1.10.0 (#2933)
dependabot[bot] Dec 19, 2022
8f2bbd2
Resolve some code review comments
zmanian Dec 19, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed TypeMsg constants (cosmos#2478)
* removed TypeMsg constants

* updated changelog.md

* removed associated tests

* removed new variable

Co-authored-by: colin axnér <[email protected]>
alizahidraja and colin-axner authored Oct 7, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 126b6f3a1a6d1ece596e3fd5f68c41e8a3441657
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -99,6 +99,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (light-clients/06-solomachine) Moving `verifyMisbehaviour` function from update.go to misbehaviour_handle.go.
* (apps/27-interchain-accounts) [\#2297](https://github.com/cosmos/ibc-go/pull/2297) Adding cli command to generate ICS27 packet data.
* (modules/core/keeper) [\#1728](https://github.com/cosmos/ibc-go/pull/2399) Updated channel callback errors to include portID & channelID for better identification of errors.
* [\#2434](https://github.com/cosmos/ibc-go/pull/2478) Removed all `TypeMsg` constants

### Features

16 changes: 0 additions & 16 deletions modules/apps/29-fee/types/msgs.go
Original file line number Diff line number Diff line change
@@ -10,12 +10,6 @@ import (
host "github.com/cosmos/ibc-go/v6/modules/core/24-host"
)

// msg types
const (
TypeMsgPayPacketFee = "payPacketFee"
TypeMsgPayPacketFeeAsync = "payPacketFeeAsync"
)

// NewMsgRegisterPayee creates a new instance of MsgRegisterPayee
func NewMsgRegisterPayee(portID, channelID, relayerAddr, payeeAddr string) *MsgRegisterPayee {
return &MsgRegisterPayee{
@@ -159,11 +153,6 @@ func (msg MsgPayPacketFee) Route() string {
return RouterKey
}

// Type implements sdk.Msg
func (msg MsgPayPacketFee) Type() string {
return TypeMsgPayPacketFee
}

// GetSignBytes implements sdk.Msg.
func (msg MsgPayPacketFee) GetSignBytes() []byte {
return sdk.MustSortJSON(AminoCdc.MustMarshalJSON(&msg))
@@ -205,11 +194,6 @@ func (msg MsgPayPacketFeeAsync) Route() string {
return RouterKey
}

// Type implements sdk.Msg
func (msg MsgPayPacketFeeAsync) Type() string {
return TypeMsgPayPacketFeeAsync
}

// GetSignBytes implements sdk.Msg.
func (msg MsgPayPacketFeeAsync) GetSignBytes() []byte {
return sdk.MustSortJSON(AminoCdc.MustMarshalJSON(&msg))
10 changes: 0 additions & 10 deletions modules/apps/29-fee/types/msgs_test.go
Original file line number Diff line number Diff line change
@@ -237,11 +237,6 @@ func TestMsgPayPacketFeeRoute(t *testing.T) {
require.Equal(t, types.RouterKey, msg.Route())
}

func TestMsgPayPacketFeeType(t *testing.T) {
var msg types.MsgPayPacketFee
require.Equal(t, "payPacketFee", msg.Type())
}

func TestMsgPayPacketFeeGetSignBytes(t *testing.T) {
fee := types.NewFee(defaultRecvFee, defaultAckFee, defaultTimeoutFee)
msg := types.NewMsgPayPacketFee(fee, ibctesting.MockFeePort, ibctesting.FirstChannelID, defaultAccAddress, nil)
@@ -391,11 +386,6 @@ func TestMsgPayPacketFeeAsyncRoute(t *testing.T) {
require.Equal(t, types.RouterKey, msg.Route())
}

func TestMsgPayPacketFeeAsyncType(t *testing.T) {
var msg types.MsgPayPacketFeeAsync
require.Equal(t, "payPacketFeeAsync", msg.Type())
}

func TestMsgPayPacketFeeAsyncGetSignBytes(t *testing.T) {
packetID := channeltypes.NewPacketID(ibctesting.MockFeePort, ibctesting.FirstChannelID, 1)
fee := types.NewFee(defaultRecvFee, defaultAckFee, defaultTimeoutFee)
10 changes: 0 additions & 10 deletions modules/apps/transfer/types/msgs.go
Original file line number Diff line number Diff line change
@@ -10,11 +10,6 @@ import (
host "github.com/cosmos/ibc-go/v6/modules/core/24-host"
)

// msg types
const (
TypeMsgTransfer = "transfer"
)

// NewMsgTransfer creates a new MsgTransfer instance
//
//nolint:interfacer
@@ -39,11 +34,6 @@ func (MsgTransfer) Route() string {
return RouterKey
}

// Type implements sdk.Msg
func (MsgTransfer) Type() string {
return TypeMsgTransfer
}

// ValidateBasic performs a basic check of the MsgTransfer fields.
// NOTE: timeout height or timestamp values can be 0 to disable the timeout.
// NOTE: The recipient addresses format is not validated as the format defined by
7 changes: 0 additions & 7 deletions modules/apps/transfer/types/msgs_test.go
Original file line number Diff line number Diff line change
@@ -46,13 +46,6 @@ func TestMsgTransferRoute(t *testing.T) {
require.Equal(t, RouterKey, msg.Route())
}

// TestMsgTransferType tests Type for MsgTransfer
func TestMsgTransferType(t *testing.T) {
msg := NewMsgTransfer(validPort, validChannel, coin, addr1, addr2, timeoutHeight, 0)

require.Equal(t, "transfer", msg.Type())
}

func TestMsgTransferGetSignBytes(t *testing.T) {
msg := NewMsgTransfer(validPort, validChannel, coin, addr1, addr2, timeoutHeight, 0)
expected := fmt.Sprintf(`{"type":"cosmos-sdk/MsgTransfer","value":{"receiver":"%s","sender":"%s","source_channel":"testchannel","source_port":"testportid","timeout_height":{"revision_height":"10"},"token":{"amount":"100","denom":"atom"}}}`, addr2, addr1)
8 changes: 0 additions & 8 deletions modules/core/02-client/types/msgs.go
Original file line number Diff line number Diff line change
@@ -9,14 +9,6 @@ import (
"github.com/cosmos/ibc-go/v6/modules/core/exported"
)

// message types for the IBC client
const (
TypeMsgCreateClient string = "create_client"
TypeMsgUpdateClient string = "update_client"
TypeMsgUpgradeClient string = "upgrade_client"
TypeMsgSubmitMisbehaviour string = "submit_misbehaviour"
)

var (
_ sdk.Msg = &MsgCreateClient{}
_ sdk.Msg = &MsgUpdateClient{}
6 changes: 3 additions & 3 deletions modules/core/04-channel/keeper/keeper_test.go
Original file line number Diff line number Diff line change
@@ -105,13 +105,13 @@ func (suite *KeeperTestSuite) TestGetAllChannelsWithPortPrefix() {
name: "transfer channel is retrieved with prefix",
prefix: "tra",
allChannels: allChannels,
expectedChannels: []types.IdentifiedChannel{types.NewIdentifiedChannel(transfertypes.TypeMsgTransfer, ibctesting.FirstChannelID, types.Channel{})},
expectedChannels: []types.IdentifiedChannel{types.NewIdentifiedChannel(transfertypes.PortID, ibctesting.FirstChannelID, types.Channel{})},
},
{
name: "matches port with full name as prefix",
prefix: transfertypes.TypeMsgTransfer,
prefix: transfertypes.PortID,
allChannels: allChannels,
expectedChannels: []types.IdentifiedChannel{types.NewIdentifiedChannel(transfertypes.TypeMsgTransfer, ibctesting.FirstChannelID, types.Channel{})},
expectedChannels: []types.IdentifiedChannel{types.NewIdentifiedChannel(transfertypes.PortID, ibctesting.FirstChannelID, types.Channel{})},
},
{
name: "no ports match prefix",