-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control channel #489
Merged
Merged
Add control channel #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can confirm that this fixes issues I am seeing with jupyter_client v6.0 |
Chilipp
added a commit
to psyplot/psyplot-gui
that referenced
this pull request
Mar 16, 2020
This commit will be reverted when ipython/ipykernel#489 is implemented.
It would be nice if this PR could be reviewed/merged, quite a lot of people are affected by the 6.0 release of jupyter_client. |
blink1073
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Chilipp
added a commit
to psyplot/psy-simple
that referenced
this pull request
Mar 20, 2020
This commit will be reverted when ipython/ipykernel#489 is implemented.
Any plan to cut a release soon? |
See #492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jupyter_client
v6.0.0 requires a control channel.Fixes jupyter/jupyter_client#523