Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control channel #489

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Conversation

davidbrochart
Copy link
Collaborator

jupyter_client v6.0.0 requires a control channel.
Fixes jupyter/jupyter_client#523

@astrofrog
Copy link

I can confirm that this fixes issues I am seeing with jupyter_client v6.0

@davidbrochart
Copy link
Collaborator Author

It would be nice if this PR could be reviewed/merged, quite a lot of people are affected by the 6.0 release of jupyter_client.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 8ed79e9 into ipython:master Mar 17, 2020
@davidbrochart davidbrochart deleted the jupyter_client_6 branch March 17, 2020 13:45
@blink1073 blink1073 added this to the 5.2 milestone Mar 17, 2020
Chilipp added a commit to psyplot/psy-simple that referenced this pull request Mar 20, 2020
This commit will be reverted when ipython/ipykernel#489
is implemented.
@davidbrochart
Copy link
Collaborator Author

Any plan to cut a release soon?

@blink1073
Copy link
Contributor

See #492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 6.0.0 breaks qtconsole
3 participants