Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alter skip-traceback to make traceback collapsed, rather than just omitted entirely #957

Merged
merged 3 commits into from
Apr 22, 2017

Conversation

jcb91
Copy link
Member

@jcb91 jcb91 commented Apr 11, 2017

fixes #935 (I think!)

@jcb91 jcb91 merged commit 9aa792e into ipython-contrib:master Apr 22, 2017
@juhasch
Copy link
Member

juhasch commented Apr 23, 2017

Looks nice. When testing this with Chrome on Mac:

  • I can't disable hiding tracebacks with the toolbar button
  • Copying to clipboard does not work, or copies the code cell contents

@jcb91
Copy link
Member Author

jcb91 commented Apr 24, 2017

  • I can't disable hiding tracebacks with the toolbar button

This is presumably the same as mentioned in #970. I expect I've merged this with some error in 😞. I'll have a look

  • Copying to clipboard does not work, or copies the code cell contents

This was definitely working for me in chrome on Ubuntu 16.04, but again, I may well have broken something somewhere, so I'll investigate

@jcb91
Copy link
Member Author

jcb91 commented Apr 24, 2017

  • I can't disable hiding tracebacks with the toolbar button

So what exactly happens here? You have the tracebacks hidden, you click the toolbar button, they don't un-hide? Or newly-created cells still have theirs hidden? It seems to be working ok for me, thought there does seem to be a bug that doesn't correctly hide tracebacks the first time the toggle is activated (though it does work if you toggle off-on-off, weirdly).

  • Copying to clipboard does not work, or copies the code cell contents

The copying seems to work fine for me on notebook 4.3.1, Chrome 56.0.2924.87 and Firefox 53.0, on Ubuntu 16.04. What notebook version are you using? Do you have an example notebook I could try? If it comes to it, I guess I can fire up OSX, although it runs at a snails pace for me at the moment 😆

@jcb91 jcb91 deleted the traceback branch April 24, 2017 15:46
@juhasch
Copy link
Member

juhasch commented Apr 24, 2017

OK, I see you removed the toolbar button. And my visual memory remembered the wrong button 😬

This is what happens with the clipoard:
traceback

@juhasch
Copy link
Member

juhasch commented Apr 24, 2017

Not very different with Firefox:
traceback-ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] collapsible traceback
2 participants