Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading of skill, remove stale nbextensions no_exec_dunder and nbviewer_theme #906

Merged
merged 3 commits into from
Mar 4, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/jupyter_contrib_nbextensions/migrate.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def _migrate_require_paths(logger=None):
mappings = {
'notebook': [
('config/config_menu/main', 'nbextensions_configurator/config_menu/main'), # noqa: E501
('skill/skill', 'skill/main'),
('yapf_ext/yapf_ext', 'code_prettify/code_prettify'),
] + [(req, req.split('/', 1)[1]) for req in [
'codemirrormode/skill/skill',
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

14 changes: 14 additions & 0 deletions src/jupyter_contrib_nbextensions/nbextensions/skill/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
define(function() {
"use strict";
// jupyter nbextensions must export a load_ipython_extension function to
// avoid throwing an error. Also, loading the module should do nothing
// unless the function is called, so we wrap requiring the codemirror mode
// in the load call.
return {
load_ipython_extension: function () {
require(['./skill'], function () {
console.log('[SKILL Syntax] loaded');
});
}
};
});
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ Type: IPython Notebook Extension
Name: SKILL Syntax
Description: Enable SKILL syntax support for CodeMirror
Link: README.md
Main: skill.js
Main: main.js
Compatibility: 4.x