Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure gutter is loaded before initializing it. #900

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

juhasch
Copy link
Member

@juhasch juhasch commented Feb 20, 2017

Overlooked that at #897.

@jcb91
Copy link
Member

jcb91 commented Feb 20, 2017

Is this necessary? The define should only execute once the addon's been loaded anyway, no?

@juhasch
Copy link
Member Author

juhasch commented Feb 20, 2017

Unfortunately yes. Without, it looks like this:
bildschirmfoto 2017-02-20 um 22 31 03

@jcb91
Copy link
Member

jcb91 commented Feb 20, 2017

ok, that's strange!

I think it must be more of a timing problem though, since the define([ call is analogous to the require([ one in terms of loading order, so if anything it should load the addon earlier. But whatever, if this fixes it for now, it's not worth worrying about 😄

@juhasch
Copy link
Member Author

juhasch commented Feb 20, 2017

It is a timing problem, and this is the least ugly hack I could come up with.
The gutter stuff can be strange...
If you have an idea what to do about it, you're welcome. But don't waste your time on it.

@jcb91
Copy link
Member

jcb91 commented Feb 20, 2017

The gutter stuff can be strange...

No kidding!

If you have an idea what to do about it, you're welcome. But don't waste your time on it.

Yeah, it looks too complicated to quickly think about, so if this ides fixes it for now, I think you've got the right plan here!

@juhasch juhasch merged commit 882e7ad into ipython-contrib:master Feb 22, 2017
@juhasch juhasch deleted the fix/runtools2 branch March 26, 2017 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants