Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[highlighter] Minor typo update + cleaning #899

Merged
merged 1 commit into from
Feb 26, 2017

Conversation

jfbercher
Copy link
Member

  • Minor typo update which prevented correct display of readme in nbextensions_configurator
  • Cleaned dead highlighter.old.js file

@jcb91
Copy link
Member

jcb91 commented Feb 26, 2017

I've coincidentally just patched the configurator to fix the display issue with syntax-highlighting schemes which can't be found, so the ipython highlight scheme will just display unhighlighted, rather than preventing display of the entire readme. However, I haven't yet looked into how to add the ipython syntax (which adds support for magics) to the readme renderer in the same way that it's added for the general notebook...

@jfbercher
Copy link
Member Author

@jcb91 Nice that you improve highlighting support in the configurator!
I am merging this PR for now (the highlighted code in question is pure python).

@jfbercher jfbercher merged commit c4956ac into ipython-contrib:master Feb 26, 2017
@jcb91
Copy link
Member

jcb91 commented Feb 26, 2017

Good plan to merge 👍 configurator update will be a few days while I get testing sorted out, anyway.
But given the %%javascript magic, isn't it mainly javascript? 😆

@jfbercher
Copy link
Member Author

Yes, you are right, and the code in question was definitively ipython! Let it as is for now, and we will update the highlight mode after and specify that the code to test the extension must be typed in a ipython code cell (or in the JS console as pure javascript).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants