-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[collapsible_headings] new features! #892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jcb91
commented
Feb 15, 2017
•
edited
Loading
edited
- unbind event handlers during notebook loading, so collapsing/uncollapsing headings don't slow down the load, as mentioned in [large notebooks] Collapsible headings do not show up anymore #822
- allow left-arrow keyboard shortcut to skip to higher-level headings, for faster navigation
- add support for embedding collapsible_headings into nbconverted html documents, as requested in Collapsible headings: nbcovert notebook #605, nbextensions and nbconvert #847. This is done through use of an exporter model which can be applied more generally through subclassing, though at the moment, the only other example that comes to mind of embedding things in html is toc2.
allowing us to reduce dependencies for wrapper module, so it can work where Jupyter is undefined
allow main functions to work with jquery cell elements when notebook not live
… headings when a collapsed heading is already selected
I haven't yet updated any of the docs for this... |
or tests! d'oh |
👍 👍 |
Ok, I'm gonna merge this as-is, maybe add support for exporting alongside toc2 in another PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.