also remove latex_envs nbconvert_support things #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfbercher
reviewed
Nov 27, 2016
| @@ -48,8 +48,6 @@ http://nbconvert.readthedocs.io/en/latest/api/exporters.html | |||
|
|
|||
| .. autoclass:: LenvsHTMLExporter | |||
There was a problem hiding this comment.
I think that LenvsHTMLExporter can be removed too (exporter from latex_envs to HTML)
There was a problem hiding this comment.
yes, true, but this has actually already been removed in #794, so doesn't need doing again here
jfbercher
reviewed
Nov 27, 2016
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| import os | |||
|
|
|||
| from .latex_envs import LenvsHTMLExporter, LenvsLatexExporter | |||
| from latex_envs.latex_envs import LenvsHTMLExporter, LenvsLatexExporter | |||
There was a problem hiding this comment.
Not sure that we have to keep these two imports since the entry points are defined in the latex_envs.py module.
There was a problem hiding this comment.
yep, ok, I'll update shortly
- templates - fix conda env import tests
|
@jcb91 yes, I agree that it would be be better and simpler to let people use latex_envs's classes directly. I will update the documentation to reflect that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jfbercher any thoughts on whether we ought to import relevant classes into nbconvvert_support from latex_envs, as I've done so far? It seems neat for back-compatibility, but will probably get to be a pain keeping them in sync eventually, so I think maybe it's be better to just remove them altogether, and let people use
latex_envs's classes directly when they want to...