-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some travis warnings and errors #1251
Conversation
@jfbercher :the link-checker fails here:
Maybe you could take a look at it sometime ? Not sure about the two OSX errors in travis. |
@juhasch I think I already made a pr to latex_envs to fix those links, so (if that's true), we just need a new pypi/conda release there to fix this |
@jcb91 : Thanks for the PR. Do you have an idea how to fix the TLSV1 error on Travis ? |
Yes @jcb91, I have merged this one 4 days ago. Thanks. There was a incorrect link remaining in an html file. I was precisely working on a new version with some corrections and improvements, and since I have regenerated the doc, this should be fixed :-) |
I have also made a Pypi release. |
Great, so I will merge. |
Thanks @juhasch. I'm afraid I have no extra info on the TLS issue. Travis issues list seems to have a few things with the same text, but they vary in their root cause from something Travis had to fix with their ruby install to certificate errors at the remote end, so it doesn't seem immediately obvious what the right course of action would be there... |
What is the reason we need the MacOS tests anyway ? |
Oh don't they just! 😂 So frustrating, particularly when Travis' macOS infrastructure falls over, which it seems to do a couple of times a year 🙄
Yeah, it probably is, I guess. I think it felt safer when first packaging everything for pypi to just test everything to be sure it would all work. But now, I think you're right, we can fairly safely assume that macOS is unix-y enough, and the builds can be dropped (or at least made allowed-failure). Worth keeping the appveyor windows ones though, as windows is of course sometimes different, particularly with things like paths. In fact, if we're going to drop the macOS builds, we could even switch to circleCI for the Linux ones (conda-forge use circle, and it seems pretty fast, though I've no direct comparison). |
OK, so let's remove macOS at least for now. I agree keeping Windows tests is worthwhile. Any idea what the remaining appveyorartifacts error is about ? |
This build used to collect coverage files produced on appveyor, then submit them to coveralls or codecov (or maybe both? I forget). It hasn't worked fr a while, but I've not bothered to investigate why. To be honest, the coverage levels only relate to python code anyway, so are slightly misleading... |
No description provided.