Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some travis warnings and errors #1251

Merged
merged 3 commits into from
Feb 25, 2018
Merged

Conversation

juhasch
Copy link
Member

@juhasch juhasch commented Feb 24, 2018

No description provided.

@juhasch
Copy link
Member Author

juhasch commented Feb 24, 2018

@jfbercher :the link-checker fails here:

https://rawgit.com/jfbercher/jupyter_latex_envs/master/src/latex_envs/static/doc/latex_env_doc.html
(line   77) redirect  https://conda-forge.github.io/ - permanently to https://conda-forge.org/
(line  122) broken    https://github.com/benweet/stackedit/issue/187 - 404 Client Error: Not Found for url: https://github.com/benweet/stackedit/issue/187

Maybe you could take a look at it sometime ?

Not sure about the two OSX errors in travis.

@jcb91
Copy link
Member

jcb91 commented Feb 24, 2018

@juhasch I think I already made a pr to latex_envs to fix those links, so (if that's true), we just need a new pypi/conda release there to fix this

@jcb91
Copy link
Member

jcb91 commented Feb 24, 2018

Yep: jfbercher/jupyter_latex_envs#32

@juhasch
Copy link
Member Author

juhasch commented Feb 24, 2018

@jcb91 : Thanks for the PR. Do you have an idea how to fix the TLSV1 error on Travis ?

@jfbercher
Copy link
Member

Yep: jfbercher/jupyter_latex_envs#32

Yes @jcb91, I have merged this one 4 days ago. Thanks. There was a incorrect link remaining in an html file. I was precisely working on a new version with some corrections and improvements, and since I have regenerated the doc, this should be fixed :-)

@jfbercher
Copy link
Member

I have also made a Pypi release.

@juhasch
Copy link
Member Author

juhasch commented Feb 25, 2018

Great, so I will merge.

@juhasch juhasch merged commit bc2e787 into ipython-contrib:master Feb 25, 2018
@jcb91
Copy link
Member

jcb91 commented Feb 25, 2018

Thanks @juhasch. I'm afraid I have no extra info on the TLS issue. Travis issues list seems to have a few things with the same text, but they vary in their root cause from something Travis had to fix with their ruby install to certificate errors at the remote end, so it doesn't seem immediately obvious what the right course of action would be there...

@juhasch juhasch deleted the fix_travis branch February 25, 2018 10:07
@juhasch
Copy link
Member Author

juhasch commented Feb 25, 2018

What is the reason we need the MacOS tests anyway ?
They seem to take forever, and we don't have any binaries to test, so I would think testing on Linux would be enough ?

@jcb91
Copy link
Member

jcb91 commented Feb 25, 2018

They seem to take forever

Oh don't they just! 😂 So frustrating, particularly when Travis' macOS infrastructure falls over, which it seems to do a couple of times a year 🙄

I would think testing on Linux would be enough ?

Yeah, it probably is, I guess. I think it felt safer when first packaging everything for pypi to just test everything to be sure it would all work. But now, I think you're right, we can fairly safely assume that macOS is unix-y enough, and the builds can be dropped (or at least made allowed-failure). Worth keeping the appveyor windows ones though, as windows is of course sometimes different, particularly with things like paths.

In fact, if we're going to drop the macOS builds, we could even switch to circleCI for the Linux ones (conda-forge use circle, and it seems pretty fast, though I've no direct comparison).

@juhasch
Copy link
Member Author

juhasch commented Feb 25, 2018

OK, so let's remove macOS at least for now. I agree keeping Windows tests is worthwhile.

Any idea what the remaining appveyorartifacts error is about ?

@jcb91
Copy link
Member

jcb91 commented Mar 6, 2018

Any idea what the remaining appveyorartifacts error is about ?

This build used to collect coverage files produced on appveyor, then submit them to coveralls or codecov (or maybe both? I forget). It hasn't worked fr a while, but I've not bothered to investigate why. To be honest, the coverage levels only relate to python code anyway, so are slightly misleading...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants