Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lxml >=3.8.0 dependency. #1174

Merged
merged 2 commits into from
Dec 19, 2017
Merged

Remove lxml >=3.8.0 dependency. #1174

merged 2 commits into from
Dec 19, 2017

Conversation

codypiersall
Copy link

The version dependency makes it hard to install nbextensions on certain
platforms (e.g. ARM). See Issue #1172.

Remove lxml >=3.8.0 dependency.
3688a3b 
The version dependency makes it hard to install nbextensions on certain
platforms (e.g. ARM).  See Issue ipython-contrib#1172.
@codypiersall
Copy link
Author

codypiersall commented Dec 15, 2017 •
edited
Loading

PR attempting to fix #1172.

@codypiersall codypiersall mentioned this pull request Dec 15, 2017
Closed
@juhasch
Copy link
Member

juhasch commented Dec 18, 2017

Travis is happy, so this looks good to me.

On a side note: I am using berryconda on Arm, so I did not run into this problem. It provides all nice scientific Python packages in a recent version. You get lxml version 4.1.1 there.

@jcb91
[embedhtml] only import from lxml if we're actually about to use it
5810b81 
This allows nbconvert_support to import the module, even if lxml is missing
or has missing dependency libs, etc.
In this way, problems with lxml should only bother people who are
actually tryying to use this.
@jcb91
Copy link
Member

jcb91 commented Dec 19, 2017 •
edited
Loading

Well, Travis is happy because it installs lxml 4.1.1, so this PR doesn't change that 😆. However, I did test lxml down to 3.4 at least with tests running ok. I thought maybe we should keep major-version dependency for compatibility reasons (so lxml >= 3), but tbh lxml major versions don't appear to indicate backwards-incompatibility, so whatever, I think this is fine. I've added a small alteration to limit lxml imports to when it's actually used, which should hopefully help limit some of the problems people have had with incompatible dependency libs for lxml.

@jcb91 jcb91 merged commit 965c653 into ipython-contrib:master Dec 19, 2017
@codypiersall
Copy link
Author

@jcb91 Thanks for doing the extra work of installing older versions and checking that everything still works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codypiersall @juhasch @jcb91