-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chrome-clipboard fails on images with '_xsrf' argument missing from POST #918
Comments
This sounds similar to #830. Can you check if your version of nbextensions contain the fix from #831 ? You can check this by looking at http://localhost:8888/nbextensions/dragdrop/main.js and verify it contains the new |
Thanks @juhasch - I appreciate your work on these awesome extensions. Just to clarify, I can verify that line 54 of dragdrop/main.js is calling: However, chrome-clipboard/main.js has a somewhat different |
Thanks for the feedback. I thought of the other extension, as the reason for the error is most likely exactly the same: The API call needs to be updated to work with the new security measures in the notebook. Do you want to try to fix it yourself ? Otherwise I will try to come up with a fix next week. |
OK thanks, it's working now with just minor tweaks. Should I submit a pull request? I've not contributed to an open-source project before. |
Sure, that'd be great 😄 I found a handy guide if you haven't come across the workflow before: https://yangsu.github.io/pull-request-tutorial/
Well, now's your chance 😉 |
Sounds good, thanks for the link @jcb91! |
Reference Issue ipython-contrib#918. Update the API call for the PUT request to work with the new security measures in the notebook. Now uses promising_ajax() in base/js/utils/.
Update API for chrome-clipboard PUT request per #918.
should be fixed by #921, please repoen if not! |
I am on Windows 10 with Chrome 56.0.2924.87 and Javascript V8 5.6.326.50 and using Jupyter Notebook 4.4.1
I did the following:
Then I started my notebook server, used the nbextensions tab to enable chrome-clipboard and restarted my notebook server.
I verified that copy/paste works for notebook cells but does not seem to be working for images.
Trace is:
I also tried to enable the extension with
jupyter nbextension enable chrome-clipboard/main
and restarting my notebook server, but made no difference.The text was updated successfully, but these errors were encountered: