feat: Add pubsub receipt sharing notifications #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgins
added
networking
zeeshanlakhani
force-pushed
the
zl/jsonrpc
branch
2 times, most recently
from
404f538 to
e13b48d
Compare
bgins
force-pushed
the
bgins/shared-receipts
branch
2 times, most recently
from
f0138c1 to
0f75068
Compare
bgins
force-pushed
the
bgins/shared-receipts
branch
from
c66af97 to
649721f
Compare
bgins
force-pushed
the
bgins/shared-receipts
branch
from
10024d6 to
e31b2de
Compare
zeeshanlakhani
approved these changes
Nov 9, 2023
hugomrdias
pushed a commit
that referenced
this pull request
Nov 14, 2023
# Description This PR implements the following changes: - [x] Add receipt published and received notifications - [x] Update receipt sharing log messages - [x] Add receipt sharing integration test - [x] Add `remove_db` and `wait_for_socket_connection` test utilities - [x] Update JSON `peer_id` key to `peerId` ## Link to issue Implements #131 ## Type of change - [x] New feature (non-breaking change that adds functionality) - [x] Refactor (non-breaking change that updates existing functionality) ## Test plan (required) This PR includes an integration test that checks for gossiped receipts in websocket notifications and logs. --------- Co-authored-by: Zeeshan Lakhani <[email protected]>
zeeshanlakhani
added a commit
that referenced
this pull request
Nov 29, 2023
# Description This PR implements the following changes: - [x] Add receipt published and received notifications - [x] Update receipt sharing log messages - [x] Add receipt sharing integration test - [x] Add `remove_db` and `wait_for_socket_connection` test utilities - [x] Update JSON `peer_id` key to `peerId` ## Link to issue Implements #131 ## Type of change - [x] New feature (non-breaking change that adds functionality) - [x] Refactor (non-breaking change that updates existing functionality) ## Test plan (required) This PR includes an integration test that checks for gossiped receipts in websocket notifications and logs. --------- Co-authored-by: Zeeshan Lakhani <[email protected]>
bgins
added a commit
that referenced
this pull request
Nov 29, 2023
## Description
Includes:
- re-purposing of feature flags
* metrics is always a thing (on)
* monitoring is the gated feature
* The websocket-server flag is gone, we only gate push notifications
- JSON-RPC setup and RPC method register
- Prometheus exposition format to JSON parser
Other features and other fixes:
- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354
- [x] #409
- [x] #425
- [x] #426
- [x] #429
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451
- [x] #456
---------
Signed-off-by: Brian Ginsburg <[email protected]>
Signed-off-by: Zeeshan Lakhani <[email protected]>
Co-authored-by: Brian Ginsburg <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
bgins
added a commit
that referenced
this pull request
Nov 29, 2023
Includes:
- re-purposing of feature flags
* metrics is always a thing (on)
* monitoring is the gated feature
* The websocket-server flag is gone, we only gate push notifications
- JSON-RPC setup and RPC method register
- Prometheus exposition format to JSON parser
Other features and other fixes:
- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354
- [x] #409
- [x] #425
- [x] #426
- [x] #429
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451
- [x] #456
---------
Signed-off-by: Brian Ginsburg <[email protected]>
Signed-off-by: Zeeshan Lakhani <[email protected]>
Co-authored-by: Brian Ginsburg <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following changes:
remove_dbandwait_for_socket_connectiontest utilitiespeer_idkey topeerIdLink to issue
Implements #131
Type of change
Test plan (required)
This PR includes an integration test that checks for gossiped receipts in websocket notifications and logs.