Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): incorrect max_stack_height issues #3

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

marioevz
Copy link
Collaborator

I believe this change solves the max-stack-height issues by doing this trick at the start of each section creation:

code = Bytecode(min_stack_height=inputs, max_stack_height=inputs)

So now the stack operations that are performed during the construction of the code section take the input stack height as the starting point.

We are now left with three different kinds of exceptions in the remaining failing tests (when no_expectations_on_validity is not used):

  • EOFException.STACK_HEIGHT_MISMATCH
  • EOFException.STACK_HIGHER_THAN_OUTPUTS
  • EOFException.STACK_UNDERFLOW

@marioevz marioevz requested a review from pdobacz September 25, 2024 21:40
@pdobacz
Copy link
Member

pdobacz commented Sep 26, 2024

Oh, that would be great, so simple. Let me delve in and see how this impacts the codes.

@pdobacz pdobacz merged commit 4f3ce97 into ipsilon:rjumps-callf Sep 27, 2024
3 checks passed
@pdobacz
Copy link
Member

pdobacz commented Sep 27, 2024

Hey, I incorporated your commit in my branch, along with some other commits, and pushed, and GH figured it out as merged 🎉 . Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants