Timestamp Log Detailing #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timestamp is added at the head of each log line. I abandoned the previous apprach which replacing the talk_base logging class. This time, I used macro to replace LOG_TS with LOG with timestap. To the best of my knowledge, libjingle does not provide wall time clock utils, but only process or O/S clock tick. So CurrentTime class is added in new file tincan_utils.
All LOG_F is changed to LOG_TS
| */ | ||
|
|
||
| #include "tincan_utils.h" | ||
|
|
There was a problem hiding this comment.
put if defined linux here in order to disable for Windows, if not it will not compile in windows because windows does not get gettimeofday
|
if defined(LINUX) is added to prevent windows compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamp is added at the head of each log line.
I abandoned the previous apprach which replacing the talk_base
logging class.
This time, I used macro to replace LOG_TS with LOG with timestap.
To the best of my knowledge, libjingle does not provide wall time
clock utils, but only process or O/S clock tick. So CurrentTime class is
added in new file tincan_utils.