Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sequence number to advertisements #158

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

gammazero
Copy link
Collaborator

The sequence number is optional to allow backwards compatability with previous existing advertisements that do not have a sequence number.

The sequence number is optional to allow backwards compatability with previous existing advertisements that do not have a sequence number.
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (47e70e2) 62.39% compared to head (c03e29d) 61.89%.

Files Patch % Lines
ingest/schema/envelope.go 62.50% 4 Missing and 2 partials ⚠️
ingest/schema/types.go 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   62.39%   61.89%   -0.51%     
==========================================
  Files          49       49              
  Lines        4329     4348      +19     
==========================================
- Hits         2701     2691      -10     
- Misses       1333     1357      +24     
- Partials      295      300       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero marked this pull request as draft February 29, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants