-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pool Key lists and buffers in Pebble store #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
reviewed
Oct 17, 2022
Pool buffers, keys, keyer and key list in order to reduce CPU and memory footprint in Pebble store implementation. Increase merger efficiency by avoiding recursion when flattening marshalled value keys. Instead, use mod to skip to where the serialized value keys should begin. This works because varint length is always added to the begining of value keys and their length is fixed in pebble store to 20 + 1. During merge any value keys with unexpected key prefix are skipped. This automatically removes such keys from the store as they will be excluded from the merge.
e30af36
to
0606c78
Compare
Workload
|
gammazero
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pool buffers, keys, keyer and key list in order to reduce CPU and memory footprint in Pebble store implementation.
Increase merger efficiency by avoiding recursion when flattening marshalled value keys. Instead, use mod to skip to where the serialized value keys should begin. This works because varint length is always added to the begining of value keys and their length is fixed in pebble store to 20 + 1.
During merge any value keys with unexpected key prefix are skipped. This automatically removes such keys from the store as they will be excluded from the merge.