Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Move inMemory resolver to separate package #151

Closed
alanshaw opened this issue Sep 24, 2018 · 4 comments · Fixed by #188 · May be fixed by adamlaska/ipfs-js-ipfs#6
Closed

Move inMemory resolver to separate package #151

alanshaw opened this issue Sep 24, 2018 · 4 comments · Fixed by #188 · May be fixed by adamlaska/ipfs-js-ipfs#6
Assignees

Comments

@alanshaw
Copy link
Member

Removes dependence on ipfs-repo and ipfs-block-service.

@daviddias daviddias added the status/ready Ready to be worked label Oct 27, 2018
@daviddias
Copy link
Member

That feature was to make @nicola but I don't believe he ever used it. I believe you can take it out entirely

@vmx
Copy link
Member

vmx commented Oct 29, 2018

i find it quite useful, yet to trivial to create a separate package for it. What do you think of putting it into an example for js-ipld. This way the code can easily be copy&paste re-used.

@daviddias
Copy link
Member

@vmx sounds great!

@alanshaw
Copy link
Member Author

alanshaw commented Nov 6, 2018

SGTM

alanshaw pushed a commit that referenced this issue Jan 13, 2019
This removes the dependency on `ipfs-repo`, `ipfs-block-service` and `interface-datastore` and resolves #151.

BREAKING CHANGE: This module no longer exports an `inMemory` utility to create an IPLD instance that uses a block service that stores data in memory. Please use the [`ipld-in-memory`](https://www.npmjs.com/package/ipld-in-memory) module instead.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@ghost ghost assigned alanshaw Jan 13, 2019
@ghost ghost added status/in-progress In progress and removed status/ready Ready to be worked labels Jan 13, 2019
@vmx vmx closed this as completed in #188 Jan 16, 2019
vmx pushed a commit that referenced this issue Jan 16, 2019
This removes the dependency on `ipfs-repo`, `ipfs-block-service` and `interface-datastore` and resolves #151.

BREAKING CHANGE: This module no longer exports an `inMemory` utility to create an IPLD instance that uses a block service that stores data in memory. Please use the [`ipld-in-memory`](https://www.npmjs.com/package/ipld-in-memory) module instead.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@ghost ghost removed the status/in-progress In progress label Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants