Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Commit

Permalink
fixup! Make resolver() sync
Browse files Browse the repository at this point in the history
  • Loading branch information
vmx committed Apr 29, 2019
1 parent 450acc6 commit 4c75b5d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion src/resolver.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const util = require('./util')
* link, then the `remainderPath` is the part after the link that can be used
* for further resolving
*/
exports.resolve = async (binaryBlob, path) => {
exports.resolve = (binaryBlob, path) => {
let node = util.deserialize(binaryBlob)

const parts = path.split('/').filter(Boolean)
Expand Down
26 changes: 13 additions & 13 deletions test/resolver.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ describe('IPLD format resolver (local)', () => {

describe('empty node', () => {
describe('resolver.resolve', () => {
it('root', async () => {
const result = await resolver.resolve(emptyNodeBlob, '/')
it('root', () => {
const result = resolver.resolve(emptyNodeBlob, '/')
expect(result.value).to.be.eql({})
})
})

it('resolver.tree', async () => {
it('resolver.tree', () => {
const paths = resolver.tree(emptyNodeBlob).next()
expect(paths.value).to.be.undefined()
expect(paths.done).to.be.true()
Expand All @@ -68,17 +68,17 @@ describe('IPLD format resolver (local)', () => {
})

describe('resolver.resolve', () => {
it('path within scope', async () => {
const result = await resolver.resolve(nodeBlob, 'name')
it('path within scope', () => {
const result = resolver.resolve(nodeBlob, 'name')
expect(result.value).to.equal('I am a node')
})

it('path within scope, but nested', async () => {
const result = await resolver.resolve(nodeBlob, 'nest/foo/bar')
it('path within scope, but nested', () => {
const result = resolver.resolve(nodeBlob, 'nest/foo/bar')
expect(result.value).to.equal('baz')
})

it('should resolve falsy values for path within scope', async () => {
it('should resolve falsy values for path within scope', () => {
const falsyNode = {
nu11: null,
f4lse: false,
Expand All @@ -88,14 +88,14 @@ describe('IPLD format resolver (local)', () => {

const falsyNodeBlob = dagCBOR.util.serialize(falsyNode)

return Promise.all(Object.keys(falsyNode).map(async (key) => {
const result = await resolver.resolve(falsyNodeBlob, key)
Object.keys(falsyNode).map((key) => {
const result = resolver.resolve(falsyNodeBlob, key)
expect(result.value).to.equal(falsyNode[key])
}))
})
})

it('path out of scope', async () => {
const result = await resolver.resolve(nodeBlob, 'someLink/a/b/c')
it('path out of scope', () => {
const result = resolver.resolve(nodeBlob, 'someLink/a/b/c')
expect(result.value.equals(
new CID('QmaNh5d3hFiqJAGjHmvxihSnWDGqYZCn7H2XHpbttYjCNE'))
).to.be.true()
Expand Down

0 comments on commit 4c75b5d

Please sign in to comment.