Allow user defined block hooks when using two step write for selective cars #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
This is a simple but pretty obscure feature. When building cars with Selectors, we have an option for a two step write -- one step performs the traversal, while another writes the traversed cids to a file. This is important among other things so that we can get a total file size ahead of time. We also have an option in the 1-step write to call a user defined hook as we write blocks. Now, we allow the two step write to use these user-defined hooks. However, they are not called till you actually dump the file. For a variety of reasons, we need this for Filecoin, but it seems to me to be a non-controversial enough change as to allow us to merge to master?
Implementation