Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some code is deprecated and some marked for removal and assert is in incorrect order #52

Open
tdltdl opened this issue Sep 11, 2024 · 8 comments
Open

Some code is deprecated and some marked for removal and assert is in incorrect order #52

tdltdl opened this issue Sep 11, 2024 · 8 comments

Comments

@tdltdl
Copy link

tdltdl commented Sep 11, 2024 •
edited
Loading

Some examples are

  • MapRequest uses deprecated create signature (MediaType, String)
  • new Integer(0), ...

Also propose to upgrade to latest versions
All assert parameters are in the wrong order : The signature is assertEquals( expected, actual) and all test cases are like this assertEquals(asnResp.getDomain(), "af.mil") (expected is the function call and actual is the expected result...
@tdltdl tdltdl changed the title Some code is deprecated and some marked for removal Some code is deprecated and some marked for removal and assert is in incorrect order Sep 11, 2024
@tdltdl tdltdl mentioned this issue Sep 11, 2024
Closed
@tdltdl
Copy link
Author

tdltdl commented Sep 11, 2024 •
edited
Loading

Will also include updated values to the test cases as per #54.
and update some dependencies like okhttp that was reported as vulnerable

tdltdl pushed a commit to tdltdl/ipInfojava that referenced this issue Sep 11, 2024
Issue ipinfo#52:
5439fb6 
- Remove deprecated code
- upgrade dependencies (amongst other to fix CVE)
- fix typos
- fix tests expected result based on current results from IPInfo
- ordered the parameters correctly
- add comment for failed test case to know which test is failing
@max-ipinfo
Copy link
Contributor

Hi @tdltdl ! Thanks for your 3 PRs.

We will go over them as soon as we have a chance.

@tdltdl
Copy link
Author

tdltdl commented Feb 10, 2025

Hi @max-ipinfo
I hope you are fine. Do you have an ETA for checking those fixes and merging them?
Thanks!

@max-ipinfo
Copy link
Contributor

@tdltdl sorry for the wait.

My hope is to take some time tomorrow, February 21 2025, to look at your PRs.

I'll keep you posted!

@max-ipinfo
Copy link
Contributor

max-ipinfo commented Feb 21, 2025 •
edited
Loading

@tdltdl starting the review of the 3 PRs now. I'll keep you posted there directly.

@max-ipinfo
Copy link
Contributor

max-ipinfo commented Feb 22, 2025 •
edited
Loading

@tdltdl let's focus on PR #55 for now.

Sent you a first review: #55 (review)

@tdltdl
Copy link
Author

tdltdl commented Feb 22, 2025

Unit test fixes are here... So doing them in the wrong order forces us to do the same test fixes multiple times

@max-ipinfo
Copy link
Contributor

max-ipinfo commented Feb 24, 2025 •
edited
Loading

Unit test fixes are here... So doing them in the wrong order forces us to do the same test fixes multiple times

Sorry @tdltdl, I didn't understand your comment

I fixed unit tests (including their order) in 8202b74

Are you having issues rebasing your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdltdl @max-ipinfo