Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Create 2019-01-07--go-core-dev-team-weekly.md #830

Merged
merged 2 commits into from
Jan 28, 2019

Conversation

eingenito
Copy link
Contributor

No description provided.

@ghost ghost assigned eingenito Jan 7, 2019
@ghost ghost added the status/in-progress In progress label Jan 7, 2019
@daviddias daviddias added the 💫 Golang Core Dev go-ipfs, go-libp2p, go-ipld label Jan 8, 2019
- Gateway Issue - @stebalien
- Believed to be https://github.com/ipfs/go-bitswap/issues/53
- We're not connecting to providers.
- Deeper issue: we should be reconnecting to peers in a session.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reader: there are more complex issues than the ones that can be solved by a hotfix. The "Fix the Gateways" meeting was productive, Now we have some really good ideas anda tiger team / task force spearheaded by @eefahy

- CORs - @stebalien
- Our CORs headers are a bit of a mess.
- Separate implementations for the gateway/api
- Some fixes, not all: https://github.com/ipfs/go-ipfs/pull/5893
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Gateway doesn't need CORS in the first place. clients only issue GET requests to it. Going to post more comments on the PR.

Also, as communicated in the call, I volunteer to tag team this with you @Stebalien. I now see that @lidel has also been on top of it and provided lots of inputs ipfs/kubo#5893.

Copy link
Member

@lidel lidel Jan 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Gateway doesn't need CORS in the first place.

I think it is actually used. See the end of ipfs/kubo#5893 (comment)

- Done:
- vacation!
- email catch up
- unblocking daemon progress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigs could you be more descriptive here? What does it mean "unblocking daemon progress"? Is there any trail of breadcrumbs to issues and PRs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely!

@momack2
- Done:
- Holidays
- Local/Offline Talk from London Meetup published to Youtube! (writing up more on that - next monthly is Jan 23) - https://twitter.com/momack28/status/1082350145994289153
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowowowowow!!! \o/ :D Nice! 👏🏽👏🏽👏🏽

Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a suggestion for improvement in notes. Try to consider them as an artifact for someone else external to the team to read.

Items such as "some work on stuff", "did some debugging" are not informative/useful and kind of defeats the reader from trying to understand what is happening. Our work happens on Github and our chats are on IRC (which is logged), if there was exploration/conversation, there is certainly a trail of breadcrumbs a person can follow and learn about the work being done (and therefore inform other decisions or contribute to it).

@Magik6k:
- Done:
- A Bunch of reviews
- Ran go-ipfs in web browser - https://github.com/ipfs/go-ipfs/pull/5878 (WIP)
Copy link
Member

@lidel lidel Jan 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Its not just web browser, I imagine WASM runtime will be quite popular in IoT, eventually :)

@ghost ghost assigned bigs Jan 8, 2019
@eingenito eingenito merged commit ae5af5f into master Jan 28, 2019
@ghost ghost removed the status/in-progress In progress label Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💫 Golang Core Dev go-ipfs, go-libp2p, go-ipld
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants