Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize README and add License #119

Merged
merged 1 commit into from
Sep 30, 2016
Merged

Standardize README and add License #119

merged 1 commit into from
Sep 30, 2016

Conversation

RichardLitt
Copy link
Member

@jbenet jbenet added the status/in-progress In progress label Jun 24, 2016
JesseWeinstein
JesseWeinstein reviewed Jul 20, 2016
View reviewed changes
README.md

## License

[CC-BY-SA](LICENSE)
Copy link
Contributor

@JesseWeinstein JesseWeinstein Jul 20, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you mention the version and unported-ness here, also?

(edit: The "license owner" is also required by the spec.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by unported-ness. Can you clarify for me? :)

Copy link
Contributor

@JesseWeinstein JesseWeinstein Sep 28, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding version -- the most current version of CC-BY-SA is 4.0, and it is different than the previous versions. The version should probably be mentioned. Regarding unported-ness, in the 3.0 version, there were "ports" to different countries legal systems. This isn't relevant for the 4.0 version.

See https://creativecommons.org/faq/#should-i-choose-an-international-license-or-a-ported-license and https://wiki.creativecommons.org/wiki/License_Versions for more detail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's just go with 4.0. Good call.

@JesseWeinstein
Copy link
Contributor

Various quibbles and suggestions.

@RichardLitt RichardLitt force-pushed the feature/standardize-readme branch from 189881e to d0be9a6 Compare September 23, 2016 18:47
@RichardLitt
Copy link
Member Author

This needs @jbenet sign-off for the license. Might be a good idea to split this PR into two, and just have the License stuff in a separate PR. @JesseWeinstein You think the other Readme edits are fine?

@JesseWeinstein
Copy link
Contributor

Yep, the other ones look good to me.

@RichardLitt RichardLitt force-pushed the feature/standardize-readme branch from d62a3e8 to bad035e Compare September 28, 2016 15:32
@RichardLitt
Copy link
Member Author

Ok. I opened #137 to deal with that; one last review to make sure this looks ok, and then we can merge it.

@RichardLitt RichardLitt merged commit 15c2440 into master Sep 30, 2016
@RichardLitt RichardLitt removed the status/in-progress In progress label Sep 30, 2016
@RichardLitt RichardLitt deleted the feature/standardize-readme branch September 30, 2016 12:32
@RichardLitt
Copy link
Member Author

Thanks @JesseWeinstein!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseWeinstein JesseWeinstein JesseWeinstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardLitt @JesseWeinstein @jbenet