-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Pin.depth with Pin.mode string enum #16
Conversation
This enables arbitrary modes of pinning to be added in the future. Third type name 'pinset' could represent object storing all local pins.
format: int32 | ||
default: -1 | ||
minimum: -1 | ||
mode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoided type
because its often a restricted keyword
I think
|
Similarly to how pinning services handle depth (they don't) I'm pretty sure all pinning services (including Pinata) assume every pin is recursive in nature and I'm not aware of any service that specifically allows for direct pins. This may be another filter that isn't needed. |
Thanks! Sounds like we can close this in favor of (optional) #19 |
This PR removes ambiguity of
depth: -1
for recursive pins (cc @ achingbrain) and enables arbitrary modes of pinning to be added in the future.I included the third type named 'pinset', which could represent a well-known format for storing all local pins (cc @aschmahmann, we discussed something like this last week), but we can remove it if its not feasible atm.
cc @obo20