-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add experimental optimistic provide #9753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guseggert
force-pushed
the
feat/optimistic-provide
branch
2 times, most recently
from
March 25, 2023 01:12
296ed70
to
892ed83
Compare
guseggert
force-pushed
the
feat/optimistic-provide
branch
6 times, most recently
from
April 5, 2023 12:06
d730530
to
b895119
Compare
guseggert
changed the title
feat: add optimistic provide
feat: add experimental optimistic provide
Apr 5, 2023
guseggert
force-pushed
the
feat/optimistic-provide
branch
2 times, most recently
from
April 5, 2023 12:17
5857021
to
a455c98
Compare
This needs docs in |
aschmahmann
reviewed
Apr 5, 2023
Closed
dennis-tra
force-pushed
the
feat/optimistic-provide
branch
from
April 6, 2023 14:30
705efb2
to
b0fa943
Compare
guseggert
force-pushed
the
feat/optimistic-provide
branch
from
April 6, 2023 14:51
b0fa943
to
6d97b22
Compare
guseggert
force-pushed
the
feat/optimistic-provide
branch
from
April 6, 2023 18:18
6d97b22
to
8401706
Compare
BigLep
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aprovig because:
- Logically the changes made sense to me.
- This is an experimental feature
- The docs looked fine
- I know others have looked at this too
A few other thoughts:
|
guseggert
force-pushed
the
feat/optimistic-provide
branch
2 times, most recently
from
April 6, 2023 20:44
befd39f
to
c580cda
Compare
This adds the ability to enable "optimistic provide" to the default DHT client, which enables faster provides and reprovides. For more information about optimistic provide, see: https://protocollabs.notion.site/Optimistic-Provide-2c79745820fa45649d48de038516b814 Note that this feature only works when using non-custom router types. This does not include the ability to enable optimistic provide on custom routers for now, to minimize the footprint of this experimental feature. We intend on continuing to test this and improve the UX, which may or may not involve adding configuration for it to custom routers. We also plan on refactoring/redesigning custom routers more broadly so I don't want this to add more effort for maintainers and confusion for users.
guseggert
force-pushed
the
feat/optimistic-provide
branch
from
April 6, 2023 20:44
c580cda
to
8c33fd5
Compare
guseggert
force-pushed
the
feat/optimistic-provide
branch
from
April 6, 2023 20:48
8c33fd5
to
a1454aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to enable "optimistic provide" to the default
DHT client, which enables faster provides and reprovides.
For more information about optimistic provide, see:
https://protocollabs.notion.site/Optimistic-Provide-2c79745820fa45649d48de038516b814
Note that this feature only works when using non-custom router
types. This does not include the ability to enable optimistic provide
on custom routers for now, to minimize the footprint of this
experimental feature. We intend on continuing to test this and improve
the UX, which may or may not involve adding configuration for it to
custom routers. We also plan on refactoring/redesigning custom routers
more broadly so I don't want this to add more effort for maintainers
and confusion for users.