-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Swarm.AddrFilters ip address example fix #9386
Conversation
Swarm.AddrFilters example not right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx but, this isn't wrong, this is using usual CIDR syntax.
As this is just an example of what it does, I think it is better to stay that way because this is understandable by people that doesn't fully grasp multiaddr yet,
if you want you can add an example of multiaddr syntax.
Sorry for my inaccurate description. A directly usable example might be better for starter. In this way, the configuration can be completed even if the professional knowledge is insufficient. |
I agree, but I would like to keep the existing thing for thoses who know it, an example of how this could look like:
|
This should be re-opened and merged. The current example is confusing and not helpful! |
I overlooked this, sorry. One possible solution would be to edit this paragraph to be:
However I think this is a little weird because in this sentence:
Does not talk about the config direclty, it refers to:
Which refers to stuff you would want to add into the config, the connection between So an other solution could be to add a new example paragraph showing you the syntax or a list of examples. If someone opens a PR implementing either of both solution I'll merge it (or try something else if you think you have a better idea). 🙂 |
The current example
192.168.0.0/16
is wrong:/ip4/192.168.0.0/ipcidr/16
is correct.