Test/poll daemon #851
Merged
Test/poll daemon #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention that this also adds the |
| } | ||
| p := addr.Protocols() | ||
| if len(p) < 2 { | ||
| log.WithField("addr", addr).Fatal("need to protocolls in host flag.") |
There was a problem hiding this comment.
"need two protocols in host flag (/ip/tcp)"
|
|
|
this is my favorite PR in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the quest for more stable tests (#844) we also want a better way to notice when the daemon is ready to accept http requests.
Previously we had a sleep/grep construction. This uses a small go program that polls an endpoint and returns with exit code zero when it returns
http 200 ok