-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update UnixFS/MFS with auto sharding #8114
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c02f5f7
feat: update UnixFS/MFS with auto sharding
schomatis dac7742
WIP: ideas to fix sharness tests
schomatis a1c5b78
fix sharness
schomatis 04dcb59
fix t0250 sharding and update unixfs with new-dir fix
schomatis c755b85
fix: update cids
schomatis 3caa9da
test against modified interop repo for sharding changes
aschmahmann 989467e
go mod tidy
aschmahmann 5abe3dc
go fmt
aschmahmann 7e395a5
update unixfs sharding path test
aschmahmann 395652e
bump js-ipfs version used in interop tests
aschmahmann 232e96e
update example deps
aschmahmann db96295
update sharness with un-sharding feature
schomatis 168600f
[TEMP]: update to commit https://github.com/ipfs/go-unixfs/pull/99/co…
schomatis 435fd73
remove just enough entries
schomatis 374a2a0
fix unsharding sharness test
schomatis 26e39aa
fix(UnixfsAPI): better handle link error
schomatis 921abda
fix CIDv1, check against v0.10
schomatis 56866cf
bump go-mfs and go-unixfs
aschmahmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -216,7 +216,7 @@ jobs: | |
| command: | | ||
| npm init -y | ||
| npm install ipfs@^0.59.1 | ||
| npm install ipfs-interop@^7.0.3 | ||
| npm install ipfs/interop#fix/go-ipfs-automatic-sharding | ||
| npm install [email protected] | ||
| working_directory: ~/ipfs/go-ipfs/interop | ||
| - run: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this should live in go-unixfs since we'd like people to be using the automatic sharding unless they opt not to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it stands they will be using automatic sharding by default for
go-ipfs, not forgo-unixfsas a standalone library (independent of BitSwap, which is the one who introduce this restriction in the first place).Do we also want this to be a default for
go-unixfsas a library? (In that case we would set theHAMTShardingSizedefault value to 256KiB in unixfs and not here.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should just put this in go-unixfs. If at some point that library starts taking sharding sizes in a non-global fashion we can deal with it there. The point of defaults is to give people something sane to start with if they're not deeply "in the know" so we might as well give it to go-unixfs consumers as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to UnixFS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in ipfs/go-unixfs@83ad983.
Will remove this after we update UnixFS/MFS dependencies with latest fixes.