fix: omit empty pins slice when reporting pin progress #8023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we get messages of the form `{Pins: null, Progress: 100}`.
After this change, we'll get `{Progress: 100}`.
|
@achingbrain does this change have any impact on the HTTP API as far as js-ipfs is concerned? |
|
Ping @achingbrain? |
|
No, js-IPFS doesn't report pinning progress yet, I was waiting for #7938 to determine what sort of behaviour should be implemented. |
aschmahmann
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Left a question, but since it works for @achingbrain in js-ipfs LGTM
| @@ -44,8 +44,8 @@ type PinOutput struct { | |||
| } | |||
|
|
|||
| type AddPinOutput struct { | |||
| Pins []string | |||
| Progress int `json:",omitempty"` | |||
| Pins []string `json:",omitempty"` | |||
There was a problem hiding this comment.
Is the idea here that while the progress is being reported there's no reason to report the empty pins?
There was a problem hiding this comment.
Yes. Otherwise, it could look like nothing was pinned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we get messages of the form
{Pins: null, Progress: 100}. After this change, we'll get{Progress: 100}.