Feat/reprov worker #787
Merged
Feat/reprov worker #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test is |
|
Im not sure what this test is trying to show. If the routing system never returns (the routing latency is set to 'infinity') then we have no reason to expect blocks to arrive in a timely manner |
|
Oh if you're connected to someone already who has the blocks, your want list updates should work (and cause the full transfer of file) even when there is no routing system/it fails. — On Wed, Feb 18, 2015 at 12:55 AM, Jeromy Johnson [email protected]
|
|
I dont think we actually send our wantlists to all connected peers. Should that be happening? |
whyrusleeping
force-pushed
the
feat/reprov-worker
branch
2 times, most recently
from
e8b42e4 to
09886ec
Compare
|
LGTM |
whyrusleeping
force-pushed
the
feat/reprov-worker
branch
from
78f407e to
5924f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a worker to provide new blocks out of the main control path to increase the speed at which we can accept incoming blocks.