Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remote services ls always return a list #7829

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 14, 2020

Closes #7824 cc @Gozala needed for 0.8.0 (#7707)

This PR ensures ipfs pin remote service ls --enc=jsonreturns a valid JSON with an empty list, even when Pinning.RemoteServices is missing from the config (eg. right after ipfs init, before any services are added/removed)

$ ipfs pin remote service ls --stat --enc=json
{"RemoteServices":[]}

@lidel lidel added the need/review Needs a review label Dec 15, 2020
@lidel lidel added status/accepted This issue has been accepted and removed need/review Needs a review labels Dec 16, 2020
@aschmahmann aschmahmann merged commit 7588a6a into master Jan 14, 2021
@aschmahmann aschmahmann deleted the fix/pin-remote-service-ls-json branch January 14, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/accepted This issue has been accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response body is empty for /api/v0/pin/remote/services/ls
2 participants