Bubble go-merkledag 1.0.2

[hsanjuan]

go-merkledag, go-unixfs and go-path are affected.

License: MIT
Signed-off-by: Hector Sanjuan [email protected]

[hsanjuan]

I think failures here are not mine. Just tried bubbling go-merkledag 1.0.1 (without my changes) and same failures pop-up. They are in core/coreapi:

--- FAIL: TestObjectAddLink (0.00s)
        object_test.go:231: failed to get block for QmaM3thHPzZE8eDFXnoZRVC2eM3GoKTw8hLAa9z7XtnDUD: blockservice: key not found
=== RUN   TestObjectAddLinkCreate
--- FAIL: TestObjectAddLinkCreate (0.00s)
        object_test.go:279: failed to get block for QmaM3thHPzZE8eDFXnoZRVC2eM3GoKTw8hLAa9z7XtnDUD: blockservice: key not found

go-merkledag 1.0.1 wasn't bubbled yet and it used a new blockservice, which used a new bitswap, which used a newer libp2p 6.0.6. @Stebalien maybe you have an idea?

[schomatis]

@hsanjuan It would seem that the go-blockservice version used in the go-ipfs repo needs to be updated (as suggested in #5330 (comment)),

https://github.com/ipfs/go-ipfs/blob/d0a1cee9c4f36b8f6dd8e5ed2b23b123cdc499fa/package.json#L557-L559

to match the newer version 1.0.2 used in go-merkledag.

The check in

https://github.com/ipfs/go-merkledag/blob/d6d6e000ce1a76d51e4bb98da17d53eb755201cc/merkledag.go#L71-L77

is failing because of a version mismatch between the errors and ipld.ErrNotFound is not getting returned.

[whyrusleeping]

Opened #5344, the err not found mismatching has been annoying for too long.