fix pubsub pub reading stdin args #4770
Conversation
ghost
assigned 
|
Test failures in bitswap... @Stebalien any idea there? |
|
It looks like we just need a sleep here: https://github.com/ipfs/go-ipfs/blob/master/exchange/bitswap/session_test.go#L315 Cancelling a context is always an async operation, expecting it to affect something else immediately afterwards is a risky bet. In reality, we shouldnt use a context to govern this, we should have an explicit close method, but that will require more refactoring. |
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
fix/pubsub-stdin
branch
from
3696f6d to
dd40a5a
Compare
| ' | ||
|
|
||
| test_expect_success "wait until ipfs pubsub sub is ready to do work" ' | ||
| go-sleep 500ms |
There was a problem hiding this comment.
Should we poll here for something (to be sure that pubsub is ready) or not?
There was a problem hiding this comment.
I see that we do it in other places so LGTM either way.
There was a problem hiding this comment.
Ideally, but thats pretty difficult to do. For now, this is good enough
|
@victorbjelkholm this fixes #4719 |
License: MIT
Signed-off-by: Jeromy [email protected]